Make ElementFactory.cpp.tmpl generate unique names

third_party/WebKit/Source/build/scripts/templates/ElementFactory.cpp.tmpl

 {% from "macros.tmpl" import license %}
 {{ license() }}
 
 #include "{{namespace}}ElementFactory.h"
 
 #include "{{namespace}}Names.h"
 {% for tag in tags|groupby('interface') %}
 #include "core/{{namespace|lower}}/{{tag[0]}}.h"
 {% endfor %}
 {% if fallback_interface %}
 #include "core/{{namespace|lower}}/{{fallback_interface}}.h"
 {% endif %}
 {% if namespace == 'HTML' %}
 #include "core/html/custom/CustomElement.h"
 {% endif %}
 #include "core/html/custom/V0CustomElement.h"
 #include "core/html/custom/V0CustomElementRegistrationContext.h"
 #include "core/dom/Document.h"
 #include "core/frame/Settings.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/wtf/HashMap.h"
 
 namespace blink {
 
-using namespace {{namespace}}Names;
-
-typedef {{namespace}}Element* (*ConstructorFunction)(
+typedef {{namespace}}Element* (*{{namespace}}ConstructorFunction)(
     Document&,
     CreateElementFlags);
 
-typedef HashMap<AtomicString, ConstructorFunction> FunctionMap;
+typedef HashMap<AtomicString, {{namespace}}ConstructorFunction> {{namespace}}FunctionMap;
 
-static FunctionMap* g_constructors = 0;
+static {{namespace}}FunctionMap* g_{{namespace}}_constructors = 0;
 
 {% for tag in tags|sort if not tag.noConstructor %}
-static {{namespace}}Element* {{tag|symbol}}Constructor(
+static {{namespace}}Element* {{namespace}}_{{tag|symbol}}Constructor(

[fs, 2017/07/07 11:01:29]

(I guess that if one were to adhere to coding style, the function name would not
have a '_' in it. Getting a nicely cased tag name seems to be more trouble than
it's worth though... I don't think something as simple as
"{{tag.interface}}Constructor" or so would work?)

     Document& document,
     CreateElementFlags flags) {
   {% if tag.runtimeEnabled %}
   if (!RuntimeEnabledFeatures::{{tag.runtimeEnabled}}Enabled())
-    return {{fallback_interface}}::Create({{tag|symbol}}Tag, document);
+    return {{fallback_interface}}::Create({{namespace}}Names::{{tag|symbol}}Tag, document);
   {% endif %}
   return {{tag.interface}}::Create(
-      {%- if tag.multipleTagNames %}{{tag|symbol}}Tag, {% endif -%}
+      {%- if tag.multipleTagNames %}{{namespace}}Names::{{tag|symbol}}Tag, {% endif -%}
       document
       {%- if tag.constructorNeedsCreatedByParser %}, flags & kCreatedByParser{% endif -%}
   );
 }
 {% endfor %}
 
 struct Create{{namespace}}FunctionMapData {
   const QualifiedName& tag;
-  ConstructorFunction func;
+  {{namespace}}ConstructorFunction func;
 };
 
 static void create{{namespace}}FunctionMap() {
-  DCHECK(!g_constructors);
-  g_constructors = new FunctionMap;
+  DCHECK(!g_{{namespace}}_constructors);
+  g_{{namespace}}_constructors = new {{namespace}}FunctionMap;
   // Empty array initializer lists are illegal [dcl.init.aggr] and will not
   // compile in MSVC. If tags list is empty, add check to skip this.
   static const Create{{namespace}}FunctionMapData data[] = {
   {% for tag in tags|sort if not tag.noConstructor %}
-    { {{tag|symbol}}Tag, {{tag|symbol}}Constructor },
+    { {{namespace}}Names::{{tag|symbol}}Tag, {{namespace}}_{{tag|symbol}}Constructor },
   {% endfor %}
   };
   for (size_t i = 0; i < WTF_ARRAY_LENGTH(data); i++)
-    g_constructors->Set(data[i].tag.LocalName(), data[i].func);
+    g_{{namespace}}_constructors->Set(data[i].tag.LocalName(), data[i].func);
 }
 
 {{namespace}}Element* {{namespace}}ElementFactory::create{{namespace}}Element(
     const AtomicString& localName,
     Document& document,
     CreateElementFlags flags) {
-  if (!g_constructors)
+  if (!g_{{namespace}}_constructors)
     create{{namespace}}FunctionMap();
-  if (ConstructorFunction function = g_constructors->at(localName))
+  if ({{namespace}}ConstructorFunction function = g_{{namespace}}_constructors->at(localName))
     return function(document, flags);
 
   {% if namespace == 'HTML' %}
   // createElement handles custom element creation itself in order to
   // transmit exceptions.
   // TODO(dominicc): When the HTML parser can pass an error
   // reporting ExceptionState, and "v0" custom elements have been
   // removed, consolidate custom element creation into one place.
   if (flags != kCreatedByCreateElement && CustomElement::ShouldCreateCustomElement(localName)) {
     QualifiedName tagName(g_null_atom, localName, HTMLNames::xhtmlNamespaceURI);
     if (flags & kAsynchronousCustomElements)
       return CustomElement::CreateCustomElementAsync(document, tagName);
     return CustomElement::CreateCustomElementSync(document, tagName);
   }
   {% endif %}
 
   if (document.RegistrationContext() &&
       V0CustomElement::IsValidName(localName)) {
     Element* element = document.RegistrationContext()->CreateCustomTagElement(
-        document, QualifiedName(g_null_atom, localName, {{namespace_prefix}}NamespaceURI));
+        document, QualifiedName(g_null_atom, localName, {{namespace}}Names::{{namespace_prefix}}NamespaceURI));
     SECURITY_DCHECK(element->Is{{namespace}}Element());
     return To{{namespace}}Element(element);
   }
 
-  return {{fallback_interface}}::Create(QualifiedName(g_null_atom, localName, {{namespace_prefix}}NamespaceURI), document);
+  return {{fallback_interface}}::Create(QualifiedName(g_null_atom, localName, {{namespace}}Names::{{namespace_prefix}}NamespaceURI), document);
 }
 
 } // namespace blink