Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2965273002:
Remove ScopedVector from gin/. (Closed)
|
Created:
3 years, 5 months ago by Avi (use Gerrit) Modified:
3 years, 5 months ago Reviewers:
jochen (gone - plz use gerrit) CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ScopedVector from gin/.
BUG=554289
Review-Url: https://codereview.chromium.org/2965273002
Cr-Commit-Position: refs/heads/master@{#484922}
Committed: https://chromium.googlesource.com/chromium/src/+/6f1faebd4e3e63d96ec3e262b88f278a54676a4a
Patch Set 1 #
Messages
Total messages: 28 (24 generated)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
avi@chromium.org changed reviewers: + jochen@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by avi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by avi@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499438735112070, "parent_rev":
"e86c74ee8e06e2a7538b273efe5e4f17fc0c38f9", "commit_rev":
"6f1faebd4e3e63d96ec3e262b88f278a54676a4a"}
Message was sent while issue was closed.
Description was changed from ========== Remove ScopedVector from gin/. BUG=554289 ========== to ========== Remove ScopedVector from gin/. BUG=554289 Review-Url: https://codereview.chromium.org/2965273002 Cr-Commit-Position: refs/heads/master@{#484922} Committed: https://chromium.googlesource.com/chromium/src/+/6f1faebd4e3e63d96ec3e262b88f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6f1faebd4e3e63d96ec3e262b88f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
