Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1102)

Unified Diff: gin/modules/module_registry.h

Issue 2965273002: Remove ScopedVector from gin/. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gin/modules/module_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/modules/module_registry.h
diff --git a/gin/modules/module_registry.h b/gin/modules/module_registry.h
index 9bbfd6e0b925dc59639b4f1634dc683aa3cb8a16..c1d3a002a2d31dc139486b2a0587b91fbd3de141 100644
--- a/gin/modules/module_registry.h
+++ b/gin/modules/module_registry.h
@@ -10,11 +10,11 @@
#include <memory>
#include <set>
#include <string>
+#include <vector>
#include "base/callback.h"
#include "base/compiler_specific.h"
#include "base/macros.h"
-#include "base/memory/scoped_vector.h"
#include "base/observer_list.h"
#include "gin/gin_export.h"
#include "v8/include/v8.h"
@@ -77,7 +77,7 @@ class GIN_EXPORT ModuleRegistry {
}
private:
- typedef ScopedVector<PendingModule> PendingModuleVector;
+ typedef std::vector<std::unique_ptr<PendingModule>> PendingModuleVector;
typedef std::multimap<std::string, LoadModuleCallback> LoadModuleCallbackMap;
explicit ModuleRegistry(v8::Isolate* isolate);
« no previous file with comments | « no previous file | gin/modules/module_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698