[Android WebAPK] Make variations only control whether WebAPKs can be installed

[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133, 739497, 695284
Review-Url: https://codereview.chromium.org/2965233003
Cr-Commit-Position: refs/heads/master@{#484722}
Committed: https://chromium.googlesource.com/chromium/src/+/001f557bcaa2a1064874b69e67b1e30c2688cad0

[pkotwicz, 2017-07-06 16:08:52]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2017-07-06 16:08:53]

Yaron, can you please take a look?

[pkotwicz, 2017-07-06 16:10:22]

Yaron, can you please take a look at the CL AND review the CL?

[pkotwicz, 2017-07-06 16:10:35]

Description was changed from

==========
[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133
==========

to

==========
[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133
==========

[pkotwicz, 2017-07-06 16:16:02]

Patchset #1 (id:1) has been deleted

[Yaron, 2017-07-06 17:01:22]

Description was changed from

==========
[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133
==========

to

==========
[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133, 739497, 695284
==========

[Yaron, 2017-07-06 17:09:15]

good start but I'd like to cut out even mroe

https://codereview.chromium.org/2965233003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
(right):

https://codereview.chromium.org/2965233003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:62:
private static boolean canInstallWebApk() {
I think you can go one step further. Remember we talked earlier this week about
how googleplayinstallstate is actually the wrong thing and irrelevant.

I'd propose that you remove |canInstallWebApk| from java, get rid of all the
java side preferences stuff (cacheEnabledState.. and isEnabledInPrefs) and just
straight consult the finch flag from native.

[pkotwicz, 2017-07-06 18:49:16]

https://codereview.chromium.org/2965233003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java
(right):

https://codereview.chromium.org/2965233003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:62:
private static boolean canInstallWebApk() {
Changing the googleplayinstallstate call is your job :) I specifically avoided
the temptation to refactor cacheEnabledStateForNextLaunch() and
computeGooglePlayInstallState() because I knew that you would be modifying those
shortly

[Yaron, 2017-07-06 18:59:58]

The CQ bit was checked by yfriedman@chromium.org

[Yaron, 2017-07-06 18:59:58]

lgtm

[commit-bot: I haz the power, 2017-07-06 19:00:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pkotwicz, 2017-07-06 19:24:19]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-07-06 19:24:20]

Dominick for OWNERS

[Yaron, 2017-07-06 19:28:31]

On 2017/07/06 19:24:20, pkotwicz wrote:
> Dominick for OWNERS

I have uber owners for this (chrome/android). I also feel comfortable reviewing
this but welcome feedback from Dominick if he feels differently.

[commit-bot: I haz the power, 2017-07-06 20:05:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499367598271270,
"parent_rev": "565a8819d84d46ca7ebcff46415dfcb4805ca30f", "commit_rev":
"001f557bcaa2a1064874b69e67b1e30c2688cad0"}

[commit-bot: I haz the power, 2017-07-06 20:05:58]

Description was changed from

==========
[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133, 739497, 695284
==========

to

==========
[Android WebAPK] Make variations only control whether WebAPKs can be installed

Previously, variations controlled whether:
- WebAPKs could be installed
- Already installed WebAPKs would open as WebAPKs

This CL makes variations only control whether WebAPKs can be installed

BUG=738133, 739497, 695284

Review-Url: https://codereview.chromium.org/2965233003
Cr-Commit-Position: refs/heads/master@{#484722}
Committed:
https://chromium.googlesource.com/chromium/src/+/001f557bcaa2a1064874b69e67b1...
==========

[commit-bot: I haz the power, 2017-07-06 20:06:00]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/001f557bcaa2a1064874b69e67b1...

[dominickn, 2017-07-07 00:14:14]

Happy to have Yaron decide if I need to be brought in on a case by case basis.
:)