Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2965233003: [Android WebAPK] Make variations only control whether WebAPKs can be installed (Closed)
Patch Set: Merge branch 'master' into chrome_webapk_host Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 49114fc5dd176d064a055951e586355ba5d0629a..b6e6a372e023161a2ddd0da550e2aac15574af8e 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -35,7 +35,6 @@ import org.chromium.chrome.browser.instantapps.InstantAppsHandler;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tab.TabRedirectHandler;
import org.chromium.chrome.browser.test.ChromeBrowserTestRule;
-import org.chromium.chrome.browser.webapps.ChromeWebApkHost;
import org.chromium.ui.base.PageTransition;
import org.chromium.webapk.lib.common.WebApkConstants;
@@ -126,7 +125,6 @@ public class ExternalNavigationHandlerTest {
@Before
public void setUp() {
mDelegate.mQueryIntentOverride = null;
- ChromeWebApkHost.initForTesting(false); // disabled by default
RecordHistogram.setDisabledForTests(true);
}
@@ -1195,18 +1193,6 @@ public class ExternalNavigationHandlerTest {
.expecting(OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
}
- /**
- * Test that tapping a link which falls solely into the scope of a WebAPK does not bypass the
- * intent picker if WebAPKs are not enabled.
- */
- @Test
- @SmallTest
- public void testLaunchWebApk_WebApkNotEnabled() {
- checkUrl(WEBAPK_SCOPE)
- .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
- START_OTHER_ACTIVITY);
- }
-
/**
* Test that tapping a link which falls solely in the scope of a WebAPK launches a WebAPK
* without showing the intent picker if WebAPKs are enabled.
@@ -1214,7 +1200,6 @@ public class ExternalNavigationHandlerTest {
@Test
@SmallTest
public void testLaunchWebApk_BypassIntentPicker() {
- ChromeWebApkHost.initForTesting(true);
checkUrl(WEBAPK_SCOPE)
.expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT, START_WEBAPK);
}
@@ -1226,7 +1211,6 @@ public class ExternalNavigationHandlerTest {
@Test
@SmallTest
public void testLaunchWebApk_ShowIntentPickerMultipleIntentHandlers() {
- ChromeWebApkHost.initForTesting(true);
checkUrl(WEBAPK_WITH_NATIVE_APP_SCOPE)
.expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
START_OTHER_ACTIVITY);
@@ -1239,7 +1223,6 @@ public class ExternalNavigationHandlerTest {
@Test
@SmallTest
public void testLaunchWebApk_BypassIntentPickerFromAnotherWebApk() {
- ChromeWebApkHost.initForTesting(true);
checkUrl(WEBAPK_SCOPE)
.withReferrer(WEBAPK_WITH_NATIVE_APP_SCOPE)
.withWebApkPackageName(WEBAPK_WITH_NATIVE_APP_PACKAGE_NAME)
@@ -1254,7 +1237,6 @@ public class ExternalNavigationHandlerTest {
@Test
@SmallTest
public void testLaunchWebApk_ShowIntentPickerInvalidWebApk() {
- ChromeWebApkHost.initForTesting(true);
checkUrl(COUNTERFEIT_WEBAPK_SCOPE)
.expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
START_OTHER_ACTIVITY);
@@ -1267,7 +1249,6 @@ public class ExternalNavigationHandlerTest {
@Test
@SmallTest
public void testLaunchWebApk_StayInSameWebApk() {
- ChromeWebApkHost.initForTesting(true);
checkUrl(WEBAPK_SCOPE + "/new.html")
.withWebApkPackageName(WEBAPK_PACKAGE_NAME)
.expecting(OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);

Powered by Google App Engine
This is Rietveld 408576698