Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2965183002: Remove DO_NOT_USE from CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE (Closed)

Created:
3 years, 5 months ago by raymes
Modified:
3 years, 5 months ago
Reviewers:
Timothy Loh, estark
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DO_NOT_USE from CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE We were originally planning to make content settings type a string, but that effort was never completed. This comment is just adding confusion at the moment. Review-Url: https://codereview.chromium.org/2965183002 Cr-Commit-Position: refs/heads/master@{#485432} Committed: https://chromium.googlesource.com/chromium/src/+/c985ba1142b3acd48c22061fee864724ea527791

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/common/common_param_traits_macros.h View 1 chunk +1 line, -2 lines 0 comments Download
M components/content_settings/core/common/content_settings.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/common/content_settings_types.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
raymes
3 years, 5 months ago (2017-07-06 05:22:19 UTC) #2
Timothy Loh
On 2017/07/06 05:22:19, raymes wrote: lgtm
3 years, 5 months ago (2017-07-06 05:27:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965183002/1
3 years, 5 months ago (2017-07-06 06:07:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/481604)
3 years, 5 months ago (2017-07-06 06:14:05 UTC) #7
raymes
+estark for trivial rename in chrome/common/common_param_traits_macros.h
3 years, 5 months ago (2017-07-10 00:32:29 UTC) #9
estark
chrome/common/common_param_traits_macros.h lgtm
3 years, 5 months ago (2017-07-10 18:10:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965183002/20001
3 years, 5 months ago (2017-07-10 22:42:21 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 22:47:56 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c985ba1142b3acd48c22061fee86...

Powered by Google App Engine
This is Rietveld 408576698