components/content_settings/core/common/content_settings.cc - Issue 2965183002: Remove DO_NOT_USE from CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings.cc

Issue 2965183002: Remove DO_NOT_USE from CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE (Closed)

Patch Set: . Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/content_settings/core/common/content_settings.cc

diff --git a/components/content_settings/core/common/content_settings.cc b/components/content_settings/core/common/content_settings.cc

index 134529971ed8396156d99891c44f471397a55b15..e1dddb6ae9d2aa7f51580723c2809f17a2f3bc11 100644

--- a/components/content_settings/core/common/content_settings.cc

+++ b/components/content_settings/core/common/content_settings.cc

@@ -80,7 +80,7 @@ int ContentSettingTypeToHistogramValue(ContentSettingsType content_setting,

return a.type < b.type;

}));

static_assert(kHistogramValue[kNumHistogramValues - 1].type ==

- CONTENT_SETTINGS_NUM_TYPES_DO_NOT_USE - 1,

+ CONTENT_SETTINGS_NUM_TYPES - 1,

"Update content settings histogram lookup");

const HistogramValue* found = std::lower_bound(