Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Deprecate flags for Cubic fixes: FLAGS_quic_reloadable_flag_quic_fix_beta_last_max, gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates, gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

https://codereview.chromium.org/2968553002/


Create a new QUIC BBR ack aggregation patch which allows extra CWND only when bytes in flight has gone below the target bytes in flight recently.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

https://codereview.chromium.org/2959373002/


Removing NackPackets from gfe/quic/core/quic_connection_test.cc
Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

https://codereview.chromium.org/2963063002/


Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

https://codereview.chromium.org/2962773003/


Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

https://codereview.chromium.org/2961133002/


The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

https://codereview.chromium.org/2962043002/


Allow trailing headers with duplicate keys. Protected by FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

https://codereview.chromium.org/2963863002/


In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

https://codereview.chromium.org/2962953002/


Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

https://codereview.chromium.org/2961123002/


Add a new connection option(BBRR) to enable BBR's rate based recovery.  Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

https://codereview.chromium.org/2962033002/



In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

https://codereview.chromium.org/2961113002/


Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

https: //codereview.chromium.org/2963853002/
Review-Url: https://codereview.chromium.org/2964583002
Cr-Commit-Position: refs/heads/master@{#483766}
Committed: https://chromium.googlesource.com/chromium/src/+/73632b8bb4b7b930760a18c68f8e1fc818a32b16

[wangyix1, 2017-06-29 20:25:45]

The CQ bit was checked by wangyix@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 20:26:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wangyix1, 2017-06-29 21:01:06]

Description was changed from

==========
Updated flags


Deprecate flags for Cubic fixes:
FLAGS_quic_reloadable_flag_quic_fix_beta_last_max,
gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates,
gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and
gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

Create a new QUIC BBR ack aggregation patch which allows extra CWND only when
bytes in flight has gone below the target bytes in flight recently.  Protected
by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

Removing NackPackets from gfe/quic/core/quic_connection_test.cc Removing the
Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

Allow trailing headers with duplicate keys. Protected by
FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

Add a new connection option(BBRR) to enable BBR's rate based recovery. 
Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for
acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

BUG=
==========

to

==========
Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Deprecate flags for Cubic fixes:
FLAGS_quic_reloadable_flag_quic_fix_beta_last_max,
gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates,
gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and
gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

https://codereview.chromium.org/2968553002/


Create a new QUIC BBR ack aggregation patch which allows extra CWND only when
bytes in flight has gone below the target bytes in flight recently.  Protected
by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

https://codereview.chromium.org/2959373002/


Removing NackPackets from gfe/quic/core/quic_connection_test.cc
Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

https://codereview.chromium.org/2963063002/


Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

https://codereview.chromium.org/2962773003/


In QUIC, send data is copied to streams rather than frames. Protected by
FLAGS_quic_reloadable_flag_quic_stream_owns_data.

This change is a preparation of copying data before data is consumed.

Merge internal change: 159690069

https://codereview.chromium.org/2963763003/


Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

https://codereview.chromium.org/2961133002/


The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

https://codereview.chromium.org/2962043002/


Allow trailing headers with duplicate keys. Protected by
FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

https://codereview.chromium.org/2963863002/


In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

https://codereview.chromium.org/2962953002/


Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

https://codereview.chromium.org/2961123002/


Add a new connection option(BBRR) to enable BBR's rate based recovery. 
Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

https://codereview.chromium.org/2962033002/



In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for
acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

https://codereview.chromium.org/2961113002/


Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

https://codereview.chromium.org/2963853002/
==========

[wangyix1, 2017-06-29 21:01:30]

wangyix@chromium.org changed reviewers:
+ rch@chromium.org

[wangyix1, 2017-06-29 21:01:40]

ptal

[commit-bot: I haz the power, 2017-06-29 21:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 21:42:13]

Dry run: This issue passed the CQ dry run.

[Fan Yang, 2017-06-29 22:24:05]

On 2017/06/29 21:01:40, wangyix1 wrote:
> ptal

I think you may need to remove 159690069 from the description? I will merge :)

[Fan Yang, 2017-06-29 22:24:23]

fayang@chromium.org changed reviewers:
+ fayang@chromium.org

[wangyix1, 2017-06-29 22:31:47]

Description was changed from

==========
Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Deprecate flags for Cubic fixes:
FLAGS_quic_reloadable_flag_quic_fix_beta_last_max,
gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates,
gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and
gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

https://codereview.chromium.org/2968553002/


Create a new QUIC BBR ack aggregation patch which allows extra CWND only when
bytes in flight has gone below the target bytes in flight recently.  Protected
by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

https://codereview.chromium.org/2959373002/


Removing NackPackets from gfe/quic/core/quic_connection_test.cc
Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

https://codereview.chromium.org/2963063002/


Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

https://codereview.chromium.org/2962773003/


In QUIC, send data is copied to streams rather than frames. Protected by
FLAGS_quic_reloadable_flag_quic_stream_owns_data.

This change is a preparation of copying data before data is consumed.

Merge internal change: 159690069

https://codereview.chromium.org/2963763003/


Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

https://codereview.chromium.org/2961133002/


The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

https://codereview.chromium.org/2962043002/


Allow trailing headers with duplicate keys. Protected by
FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

https://codereview.chromium.org/2963863002/


In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

https://codereview.chromium.org/2962953002/


Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

https://codereview.chromium.org/2961123002/


Add a new connection option(BBRR) to enable BBR's rate based recovery. 
Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

https://codereview.chromium.org/2962033002/



In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for
acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

https://codereview.chromium.org/2961113002/


Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

https://codereview.chromium.org/2963853002/
==========

to

==========
Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Deprecate flags for Cubic fixes:
FLAGS_quic_reloadable_flag_quic_fix_beta_last_max,
gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates,
gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and
gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

https://codereview.chromium.org/2968553002/


Create a new QUIC BBR ack aggregation patch which allows extra CWND only when
bytes in flight has gone below the target bytes in flight recently.  Protected
by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

https://codereview.chromium.org/2959373002/


Removing NackPackets from gfe/quic/core/quic_connection_test.cc
Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

https://codereview.chromium.org/2963063002/


Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

https://codereview.chromium.org/2962773003/


Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

https://codereview.chromium.org/2961133002/


The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

https://codereview.chromium.org/2962043002/


Allow trailing headers with duplicate keys. Protected by
FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

https://codereview.chromium.org/2963863002/


In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

https://codereview.chromium.org/2962953002/


Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

https://codereview.chromium.org/2961123002/


Add a new connection option(BBRR) to enable BBR's rate based recovery. 
Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

https://codereview.chromium.org/2962033002/



In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for
acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

https://codereview.chromium.org/2961113002/


Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

https://codereview.chromium.org/2963853002/
==========

[wangyix1, 2017-06-29 22:32:44]

On 2017/06/29 22:24:05, Fan Yang wrote:
> On 2017/06/29 21:01:40, wangyix1 wrote:
> > ptal
> 
> I think you may need to remove 159690069 from the description? I will merge :)

Oh that's right. Removed.

[Ryan Hamilton, 2017-06-29 22:42:30]

looks good, modulo the feedback from your internal back-merge CL. Namely, doing
"using std::string" in gfe/quic/core/quic_stream_send_buffer_test.cc

[wangyix1, 2017-06-29 23:58:43]

On 2017/06/29 22:42:30, Ryan Hamilton wrote:
> looks good, modulo the feedback from your internal back-merge CL. Namely,
doing
> "using std::string" in gfe/quic/core/quic_stream_send_buffer_test.cc

quic_stream_send_buffer_test.cc is actually a new file added by fayang@'s CL
that he's now merging manually, I forgot to remove those changes from the
back-merge CL. They have now been removed.

[Ryan Hamilton, 2017-06-30 02:39:42]

lgtm

[wangyix1, 2017-06-30 18:18:56]

The CQ bit was checked by wangyix@chromium.org

[commit-bot: I haz the power, 2017-06-30 18:19:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 18:25:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498846736382730, "parent_rev":
"c33f51726eacdcc1a487b21a13611f7eab580d6d", "commit_rev":
"73632b8bb4b7b930760a18c68f8e1fc818a32b16"}

[commit-bot: I haz the power, 2017-06-30 18:25:30]

Description was changed from

==========
Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Deprecate flags for Cubic fixes:
FLAGS_quic_reloadable_flag_quic_fix_beta_last_max,
gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates,
gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and
gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

https://codereview.chromium.org/2968553002/


Create a new QUIC BBR ack aggregation patch which allows extra CWND only when
bytes in flight has gone below the target bytes in flight recently.  Protected
by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

https://codereview.chromium.org/2959373002/


Removing NackPackets from gfe/quic/core/quic_connection_test.cc
Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

https://codereview.chromium.org/2963063002/


Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

https://codereview.chromium.org/2962773003/


Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

https://codereview.chromium.org/2961133002/


The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

https://codereview.chromium.org/2962043002/


Allow trailing headers with duplicate keys. Protected by
FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

https://codereview.chromium.org/2963863002/


In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

https://codereview.chromium.org/2962953002/


Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

https://codereview.chromium.org/2961123002/


Add a new connection option(BBRR) to enable BBR's rate based recovery. 
Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

https://codereview.chromium.org/2962033002/



In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for
acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

https://codereview.chromium.org/2961113002/


Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

https://codereview.chromium.org/2963853002/
==========

to

==========
Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

Deprecate flags for Cubic fixes:
FLAGS_quic_reloadable_flag_quic_fix_beta_last_max,
gfe2_reloadable_flag_quic_enable_cubic_per_ack_updates,
gfe2_reloadable_flag_quic_fix_cubic_convex_mode, and
gfe2_reloadable_flag_quic_fix_cubic_bytes_quantization.

Merge internal change: 160312965

https://codereview.chromium.org/2968553002/


Create a new QUIC BBR ack aggregation patch which allows extra CWND only when
bytes in flight has gone below the target bytes in flight recently.  Protected
by FLAGS_quic_reloadable_flag_quic_bbr_ack_aggregation_bytes2.

Merge internal change: 160232114

https://codereview.chromium.org/2959373002/


Removing NackPackets from gfe/quic/core/quic_connection_test.cc
Removing the Remove functions from gfe/quic/core/frames/quic_ack_frame

Merge internal change: 159953097

https://codereview.chromium.org/2963063002/


Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice.

Merge internal change: 159704484

https://codereview.chromium.org/2962773003/


Removing NackPackets from gfe/quic/core/quic_sent_packet_manager_test.cc

Merge internal change: 159586807

https://codereview.chromium.org/2961133002/


The Remove functions in quic_ack_frame.cc are renamed RemoveTestOnly.

gfe/quic/core/frames/quic_frames_test.cc no longer uses them.

Merge internal change: 159564609

https://codereview.chromium.org/2962043002/


Allow trailing headers with duplicate keys. Protected by
FLAGS_quic_reloadable_flag_quic_allow_duplicate_trailers

QUIC currently treats trailers with duplicate header keys as a critical failure
(causing a CONNECION_CLOSE with QUIC_INVALID_HEADERS_STREAM_DATA). See
b/62770138.

This doesn't seem to be implementing the spec, as RFC 7541 says:

"The dynamic table can contain duplicate entries (i.e., entries with the same
name and same value). Therefore, duplicate entries MUST NOT be treated as an
error by a decoder."

In addition, it doesn't look like our spdy/http2 implementation does any sort
of similar validation check.

This CL makes QUIC more permissive of trailing headers, brings it in line with
our HTTP/2 implementation, and (hopefully) fixes b/62770138.

Merge internal change: 159476633

https://codereview.chromium.org/2963863002/


In QUIC, do not enable forced HOL blocking if
FLAGS_quic_reloadable_flag_quic_use_stream_notifier2 is on.

Merge internal change: 159473673

https://codereview.chromium.org/2962953002/


Add tests for gfe/quic/spdy_utils::CopyAndValidateTrailers.

Merge internal change: 159468423

https://codereview.chromium.org/2961123002/


Add a new connection option(BBRR) to enable BBR's rate based recovery. 
Protected by FLAGS_quic_reloadable_flag_quic_bbr_rate_recovery.

Merge internal change: 159452191

https://codereview.chromium.org/2962033002/



In QUIC, decrease verbose level QUIC_DLOG "Stream destroyed while waiting for
acks." to QUIC_DVLOG(1), and add more information.

Merge internal change: 159445987

https://codereview.chromium.org/2961113002/


Change TEST_F to simply TEST in spdy_utils_test

Rename the tests so that they can be clustered by the specific method they are
testing, and are more readable.

Merge internal change: 159430503

https: //codereview.chromium.org/2963853002/
Review-Url: https://codereview.chromium.org/2964583002
Cr-Commit-Position: refs/heads/master@{#483766}
Committed:
https://chromium.googlesource.com/chromium/src/+/73632b8bb4b7b930760a18c68f8e...
==========

[commit-bot: I haz the power, 2017-06-30 18:25:31]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73632b8bb4b7b930760a18c68f8e...