Landing Recent QUIC changes until Jun 27 19:50:48 2017 +0000

net/quic/core/frames/quic_frames_test.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/core/frames/quic_ack_frame.h"
 #include "net/quic/core/frames/quic_blocked_frame.h"
 #include "net/quic/core/frames/quic_connection_close_frame.h"
 #include "net/quic/core/frames/quic_frame.h"
 #include "net/quic/core/frames/quic_goaway_frame.h"
 #include "net/quic/core/frames/quic_mtu_discovery_frame.h"
@@ skipping 105 matching lines @@
   EXPECT_EQ("{ least_unacked: 2 }\n", stream.str());
 }
 
 TEST_F(QuicFramesTest, IsAwaitingPacket) {
   QuicAckFrame ack_frame1;
   ack_frame1.largest_observed = 10u;
   ack_frame1.packets.Add(1, 11);
   EXPECT_TRUE(IsAwaitingPacket(ack_frame1, 11u, 0u));
   EXPECT_FALSE(IsAwaitingPacket(ack_frame1, 1u, 0u));
 
-  ack_frame1.packets.Remove(10);
-  EXPECT_TRUE(IsAwaitingPacket(ack_frame1, 10u, 0u));
+  ack_frame1.packets.Add(12);
+  EXPECT_TRUE(IsAwaitingPacket(ack_frame1, 11u, 0u));
 
   QuicAckFrame ack_frame2;
   ack_frame2.largest_observed = 100u;
   ack_frame2.packets.Add(21, 100);
   EXPECT_FALSE(IsAwaitingPacket(ack_frame2, 11u, 20u));
   EXPECT_FALSE(IsAwaitingPacket(ack_frame2, 80u, 20u));
   EXPECT_TRUE(IsAwaitingPacket(ack_frame2, 101u, 20u));
 
-  ack_frame2.packets.Remove(50);
-  EXPECT_TRUE(IsAwaitingPacket(ack_frame2, 50u, 20u));
+  ack_frame2.packets.Add(102, 200);
+  EXPECT_TRUE(IsAwaitingPacket(ack_frame2, 101u, 20u));
 }
 
 TEST_F(QuicFramesTest, RemoveSmallestInterval) {
   QuicAckFrame ack_frame1;
   ack_frame1.largest_observed = 100u;
   ack_frame1.packets.Add(51, 60);
   ack_frame1.packets.Add(71, 80);
   ack_frame1.packets.Add(91, 100);
   ack_frame1.packets.RemoveSmallestInterval();
   EXPECT_EQ(2u, ack_frame1.packets.NumIntervals());
@@ skipping 23 matching lines @@
   EXPECT_TRUE(queue.Contains(53));
   EXPECT_FALSE(queue.Contains(54));
   EXPECT_EQ(51u, queue.NumPacketsSlow());
   EXPECT_EQ(1u, queue.Min());
   EXPECT_EQ(53u, queue.Max());
 
   queue.Add(70);
   EXPECT_EQ(70u, queue.Max());
 }
 
-// Tests that a queue contains the expected data after calls to Remove().
+// Tests that a queue contains the expected data after calls to RemoveUpTo().
 TEST_F(PacketNumberQueueTest, Removal) {
   PacketNumberQueue queue;
   queue.Add(0, 100);
 
   EXPECT_TRUE(queue.RemoveUpTo(51));
   EXPECT_FALSE(queue.RemoveUpTo(51));
-  queue.Remove(53);
 
   EXPECT_FALSE(queue.Contains(0));
   for (int i = 1; i < 51; ++i) {
     EXPECT_FALSE(queue.Contains(i));
   }
-  EXPECT_TRUE(queue.Contains(51));
-  EXPECT_TRUE(queue.Contains(52));
-  EXPECT_FALSE(queue.Contains(53));
-  EXPECT_TRUE(queue.Contains(54));
-  EXPECT_EQ(48u, queue.NumPacketsSlow());
+  for (int i = 51; i < 100; ++i) {
+    EXPECT_TRUE(queue.Contains(i));
+  }
+  EXPECT_EQ(49u, queue.NumPacketsSlow());
   EXPECT_EQ(51u, queue.Min());
   EXPECT_EQ(99u, queue.Max());
-
-  queue.Remove(51);
-  EXPECT_EQ(52u, queue.Min());
-  queue.Remove(99);
-  EXPECT_EQ(98u, queue.Max());
 }
 
 // Tests that a queue is empty when all of its elements are removed.
 TEST_F(PacketNumberQueueTest, Empty) {
   PacketNumberQueue queue;
   EXPECT_TRUE(queue.Empty());
   EXPECT_EQ(0u, queue.NumPacketsSlow());
 
   queue.Add(1, 100);
   EXPECT_TRUE(queue.RemoveUpTo(100));
@@ skipping 26 matching lines @@
   EXPECT_EQ(expected_intervals, actual_intervals);
 }
 
 TEST_F(PacketNumberQueueTest, IntervalLengthAndRemoveInterval) {
   PacketNumberQueue queue;
   queue.Add(1, 10);
   queue.Add(20, 30);
   queue.Add(40, 50);
   EXPECT_EQ(3u, queue.NumIntervals());
   EXPECT_EQ(10u, queue.LastIntervalLength());
-  queue.Remove(9, 21);
-  EXPECT_EQ(3u, queue.NumIntervals());
-  EXPECT_FALSE(queue.Contains(9));
-  EXPECT_FALSE(queue.Contains(20));
+
+  EXPECT_TRUE(queue.RemoveUpTo(25));
+  EXPECT_EQ(2u, queue.NumIntervals());
+  EXPECT_EQ(10u, queue.LastIntervalLength());
+  EXPECT_EQ(25u, queue.Min());
+  EXPECT_EQ(49u, queue.Max());
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace net