Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: components/toolbar/BUILD.gn

Issue 2964513002: Toolbar: Do not include vector icons if on Android with no VR. (Closed)
Patch Set: Demonstrate distributivity of negation for readability (ie. address Peter's comment) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/toolbar/toolbar_model_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/toolbar/BUILD.gn
diff --git a/components/toolbar/BUILD.gn b/components/toolbar/BUILD.gn
index d10a79f3eae9fedbb8892a9a456db1e111f2ca7c..94163637c2b524e11718ef6e49a19ac62cef49f6 100644
--- a/components/toolbar/BUILD.gn
+++ b/components/toolbar/BUILD.gn
@@ -2,9 +2,16 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/buildflag_header.gni")
import("//build/config/ui.gni")
+import("//device/vr/features/features.gni")
import("//ui/vector_icons/vector_icons.gni")
+buildflag_header("build_features") {
+ header = "features.h"
+ flags = [ "ENABLE_VR=$enable_vr" ]
+}
+
aggregate_vector_icons("toolbar_vector_icons") {
icon_directory = "vector_icons"
@@ -36,6 +43,7 @@ static_library("vector_icons") {
static_library("toolbar") {
sources = [
+ "features.h",
"toolbar_model.h",
"toolbar_model_delegate.h",
"toolbar_model_impl.cc",
@@ -49,6 +57,7 @@ static_library("toolbar") {
]
deps = [
+ ":build_features",
"//components/google/core/browser",
"//components/prefs",
"//components/resources",
@@ -59,7 +68,7 @@ static_library("toolbar") {
"//ui/gfx",
]
- if (!is_ios) {
+ if ((!is_android || enable_vr) && !is_ios) {
deps += [ ":vector_icons" ]
}
}
« no previous file with comments | « no previous file | components/toolbar/toolbar_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698