Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: components/toolbar/BUILD.gn

Issue 2964513002: Toolbar: Do not include vector icons if on Android with no VR. (Closed)
Patch Set: Demonstrate distributivity of negation for readability (ie. address Peter's comment) Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/toolbar/toolbar_model_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni")
5 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//device/vr/features/features.gni")
6 import("//ui/vector_icons/vector_icons.gni") 8 import("//ui/vector_icons/vector_icons.gni")
7 9
10 buildflag_header("build_features") {
11 header = "features.h"
12 flags = [ "ENABLE_VR=$enable_vr" ]
13 }
14
8 aggregate_vector_icons("toolbar_vector_icons") { 15 aggregate_vector_icons("toolbar_vector_icons") {
9 icon_directory = "vector_icons" 16 icon_directory = "vector_icons"
10 17
11 icons = [ 18 icons = [
12 "http.1x.icon", 19 "http.1x.icon",
13 "http.icon", 20 "http.icon",
14 "https_invalid.1x.icon", 21 "https_invalid.1x.icon",
15 "https_invalid.icon", 22 "https_invalid.icon",
16 "https_valid.1x.icon", 23 "https_valid.1x.icon",
17 "https_valid.icon", 24 "https_valid.icon",
(...skipping 11 matching lines...) Expand all
29 deps = [ 36 deps = [
30 ":toolbar_vector_icons", 37 ":toolbar_vector_icons",
31 "//skia", 38 "//skia",
32 "//ui/gfx", 39 "//ui/gfx",
33 "//ui/vector_icons", 40 "//ui/vector_icons",
34 ] 41 ]
35 } 42 }
36 43
37 static_library("toolbar") { 44 static_library("toolbar") {
38 sources = [ 45 sources = [
46 "features.h",
39 "toolbar_model.h", 47 "toolbar_model.h",
40 "toolbar_model_delegate.h", 48 "toolbar_model_delegate.h",
41 "toolbar_model_impl.cc", 49 "toolbar_model_impl.cc",
42 "toolbar_model_impl.h", 50 "toolbar_model_impl.h",
43 ] 51 ]
44 52
45 public_deps = [ 53 public_deps = [
46 "//base", 54 "//base",
47 "//components/security_state/core", 55 "//components/security_state/core",
48 "//url", 56 "//url",
49 ] 57 ]
50 58
51 deps = [ 59 deps = [
60 ":build_features",
52 "//components/google/core/browser", 61 "//components/google/core/browser",
53 "//components/prefs", 62 "//components/prefs",
54 "//components/resources", 63 "//components/resources",
55 "//components/strings", 64 "//components/strings",
56 "//components/url_formatter", 65 "//components/url_formatter",
57 "//net", 66 "//net",
58 "//ui/base", 67 "//ui/base",
59 "//ui/gfx", 68 "//ui/gfx",
60 ] 69 ]
61 70
62 if (!is_ios) { 71 if ((!is_android || enable_vr) && !is_ios) {
63 deps += [ ":vector_icons" ] 72 deps += [ ":vector_icons" ]
64 } 73 }
65 } 74 }
66 75
67 static_library("test_support") { 76 static_library("test_support") {
68 testonly = true 77 testonly = true
69 78
70 sources = [ 79 sources = [
71 "test_toolbar_model.cc", 80 "test_toolbar_model.cc",
72 "test_toolbar_model.h", 81 "test_toolbar_model.h",
73 ] 82 ]
74 83
75 public_deps = [ 84 public_deps = [
76 ":toolbar", 85 ":toolbar",
77 "//base", 86 "//base",
78 ] 87 ]
79 88
80 deps = [ 89 deps = [
81 "//components/resources", 90 "//components/resources",
82 "//ui/gfx", 91 "//ui/gfx",
83 ] 92 ]
84 93
85 if (toolkit_views) { 94 if (toolkit_views) {
86 # Needed to get the TOOLKIT_VIEWS define. 95 # Needed to get the TOOLKIT_VIEWS define.
87 deps += [ "//ui/views" ] 96 deps += [ "//ui/views" ]
88 } 97 }
89 } 98 }
OLDNEW
« no previous file with comments | « no previous file | components/toolbar/toolbar_model_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698