Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: components/toolbar/toolbar_model_impl.cc

Issue 2964513002: Toolbar: Do not include vector icons if on Android with no VR. (Closed)
Patch Set: Demonstrate distributivity of negation for readability (ie. address Peter's comment) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/toolbar/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/toolbar/toolbar_model_impl.cc
diff --git a/components/toolbar/toolbar_model_impl.cc b/components/toolbar/toolbar_model_impl.cc
index 3f20e1422dd4604c09aabf2f3b9bd9b54d3b1483..6111f92ce9eb751c0f7240067ee73926459c4a49 100644
--- a/components/toolbar/toolbar_model_impl.cc
+++ b/components/toolbar/toolbar_model_impl.cc
@@ -11,6 +11,7 @@
#include "components/prefs/pref_service.h"
#include "components/security_state/core/security_state.h"
#include "components/strings/grit/components_strings.h"
+#include "components/toolbar/features.h"
#include "components/toolbar/toolbar_model_delegate.h"
#include "components/url_formatter/elide_url.h"
#include "components/url_formatter/url_formatter.h"
@@ -21,7 +22,7 @@
#include "ui/gfx/text_elider.h"
#include "ui/gfx/vector_icon_types.h"
-#if !defined(OS_IOS)
+#if (!defined(OS_ANDROID) || BUILDFLAG(ENABLE_VR)) && !defined(OS_IOS)
#include "components/toolbar/vector_icons.h" // nogncheck
#include "ui/vector_icons/vector_icons.h" // nogncheck
#endif
@@ -73,7 +74,7 @@ security_state::SecurityLevel ToolbarModelImpl::GetSecurityLevel(
}
const gfx::VectorIcon& ToolbarModelImpl::GetVectorIcon() const {
-#if !defined(OS_IOS)
+#if (!defined(OS_ANDROID) || BUILDFLAG(ENABLE_VR)) && !defined(OS_IOS)
auto* const icon_override = delegate_->GetVectorIconOverride();
if (icon_override)
return *icon_override;
« no previous file with comments | « components/toolbar/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698