[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC.

[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2964383002
Cr-Commit-Position: refs/heads/master@{#485999}
Committed: https://chromium.googlesource.com/chromium/src/+/3493d6fdd063c42a50ca9a81d0c47831c605f550

[stkhapugin, 2017-07-03 09:44:11]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 09:44:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 09:57:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 09:57:52]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[stkhapugin, 2017-07-03 12:04:00]

This is waiting for https://codereview.chromium.org/2970703002 to fix the
redness.

[stkhapugin, 2017-07-03 13:21:14]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 13:21:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 13:59:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 13:59:15]

Dry run: This issue passed the CQ dry run.

[stkhapugin, 2017-07-03 14:23:37]

stkhapugin@chromium.org changed reviewers:
+ msarda@chromium.org

[stkhapugin, 2017-07-03 14:23:38]

PTAL

[msarda, 2017-07-03 16:14:43]

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/chrome_identity.h (right):

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity.h:17: @property(weak,
nonatomic, readonly) NSString* userEmail;
I think these should be strong from an API perspective.

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
File
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
(right):

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm:14:
__weak id<ChromeIdentityInteractionManagerDelegate> _delegate;
Remove this and use a synthesized weak property.

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm:20:
- (id<ChromeIdentityInteractionManagerDelegate>)delegate {
Remove this method.

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm:24:
- (void)setDelegate:(id<ChromeIdentityInteractionManagerDelegate>)delegate {
Remove this set now that the delegate is a regular weak property.

[msarda, 2017-07-10 15:38:12]

Is this CL still relevant? Do I need to review it again?

[stkhapugin, 2017-07-11 13:14:43]

PTAL

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
File ios/public/provider/chrome/browser/signin/chrome_identity.h (right):

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity.h:17: @property(weak,
nonatomic, readonly) NSString* userEmail;
On 2017/07/03 16:14:42, msarda wrote:
> I think these should be strong from an API perspective.

Done.

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
File
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm
(right):

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm:14:
__weak id<ChromeIdentityInteractionManagerDelegate> _delegate;
On 2017/07/03 16:14:43, msarda wrote:
> Remove this and use a synthesized weak property.

Done.

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm:20:
- (id<ChromeIdentityInteractionManagerDelegate>)delegate {
On 2017/07/03 16:14:43, msarda wrote:
> Remove this method.

Done.

https://codereview.chromium.org/2964383002/diff/1/ios/public/provider/chrome/...
ios/public/provider/chrome/browser/signin/chrome_identity_interaction_manager.mm:24:
- (void)setDelegate:(id<ChromeIdentityInteractionManagerDelegate>)delegate {
On 2017/07/03 16:14:42, msarda wrote:
> Remove this set now that the delegate is a regular weak property.

Done.

[msarda, 2017-07-11 13:54:41]

LGTM with more nits. Please address them before landing.

https://codereview.chromium.org/2964383002/diff/20001/ios/public/provider/chr...
File ios/public/provider/chrome/browser/signin/chrome_identity.h (right):

https://codereview.chromium.org/2964383002/diff/20001/ios/public/provider/chr...
ios/public/provider/chrome/browser/signin/chrome_identity.h:21: @property(weak,
nonatomic, readonly) NSString* gaiaID;
Same comment as for userEmail. Let's make them all strong.

[stkhapugin, 2017-07-12 14:54:05]

All done, thanks!

https://codereview.chromium.org/2964383002/diff/20001/ios/public/provider/chr...
File ios/public/provider/chrome/browser/signin/chrome_identity.h (right):

https://codereview.chromium.org/2964383002/diff/20001/ios/public/provider/chr...
ios/public/provider/chrome/browser/signin/chrome_identity.h:21: @property(weak,
nonatomic, readonly) NSString* gaiaID;
On 2017/07/11 13:54:41, msarda wrote:
> Same comment as for userEmail. Let's make them all strong.

Done.

[stkhapugin, 2017-07-12 14:54:15]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-07-12 14:54:15]

The patchset sent to the CQ was uploaded after l-g-t-m from msarda@chromium.org
Link to the patchset: https://codereview.chromium.org/2964383002/#ps40001
(title: "comments")

[commit-bot: I haz the power, 2017-07-12 14:54:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 16:55:50]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499871255265720,
"parent_rev": "ff9611dd2d5858f3ff65b3df37777e6c0cc3ab58", "commit_rev":
"0e924ca7b7cea554a2695833bcf2d9d0e8351b9b"}

[commit-bot: I haz the power, 2017-07-12 16:56:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499871255265720,
"parent_rev": "5426f7d0e007380b3ce7592dd959fb2b2ba4c080", "commit_rev":
"3493d6fdd063c42a50ca9a81d0c47831c605f550"}

[commit-bot: I haz the power, 2017-07-12 16:56:16]

Description was changed from

==========
[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/public/provider/chrome/browser/signin:signin to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2964383002
Cr-Commit-Position: refs/heads/master@{#485999}
Committed:
https://chromium.googlesource.com/chromium/src/+/3493d6fdd063c42a50ca9a81d0c4...
==========

[commit-bot: I haz the power, 2017-07-12 16:56:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3493d6fdd063c42a50ca9a81d0c4...