Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2970703002: Change GetAccessToken APIs so that they don't pass const ref to blocks. (Closed)

Created:
3 years, 5 months ago by stkhapugin
Modified:
3 years, 5 months ago
Reviewers:
bzanotti
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GetAccessToken APIs so that they don't pass const ref to blocks. Objective-C blocks should not be passed as const ref. This CL replaces APIs that take const ref to an Obj-C block and instead uses a pointer to a block. This makes the code compatible with ARC in the future. BUG=738861 Review-Url: https://codereview.chromium.org/2970703002 Cr-Commit-Position: refs/heads/master@{#483992} Committed: https://chromium.googlesource.com/chromium/src/+/853a46cde856de187f916e7b56734a7bba821b36

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -21 lines) Patch
M ios/public/provider/chrome/browser/signin/chrome_identity_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/chrome_identity_service.mm View 1 chunk +9 lines, -11 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h View 1 chunk +5 lines, -6 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stkhapugin
PTAL
3 years, 5 months ago (2017-07-03 11:54:51 UTC) #2
bzanotti
lgtm
3 years, 5 months ago (2017-07-03 11:57:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2970703002/1
3 years, 5 months ago (2017-07-03 11:57:49 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 12:12:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/853a46cde856de187f916e7b5673...

Powered by Google App Engine
This is Rietveld 408576698