Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2964243002:
Move c++ configs from buildtools to build/config/c++ [src-side change] (Closed)
|
Created:
3 years, 5 months ago by Tom Anderson Modified:
3 years, 5 months ago CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove c++ configs from buildtools to build/config/c++ [src-side change]
This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of
/buildtools/third_party/libc++:config into //build/config/c++/c++.
This has several advantages:
* Users can remove libc++ config if they want since it's added in
BUILDCONFIG.gn
* Allows removal of libcxx_proxy
* libc++-specific configs are in buildtools and non-libc++ configs are
in build/config
* Allows changing c++ flags without having to roll buildtools
* Removes a bit of duplicated build configuration
buildtools change:
https://codereview.chromium.org/2962423002
BUG=593874
R=thakis@chromium.org
TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng
Review-Url: https://codereview.chromium.org/2964243002
Cr-Commit-Position: refs/heads/master@{#486229}
Committed: https://chromium.googlesource.com/chromium/src/+/b5161efc5688ca9a7d45524c672b4cda02ea56ea
Patch Set 1 #Patch Set 2 : Update buildtools revision #Patch Set 3 : Rebase #
Messages
Total messages: 26 (21 generated)
Description was changed from ========== Move c++ configs from buildtools to build/config/c++ [src-side change] BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org ========== to ========== Move c++ configs from buildtools to build/config/c++ [src-side change] buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org ==========
Description was changed from ========== Move c++ configs from buildtools to build/config/c++ [src-side change] buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org ========== to ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org ==========
reviewers ptal
lgtm
lgtm
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org ========== to ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng ==========
Description was changed from ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng ========== to ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2964243002/#ps60001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499912768457310,
"parent_rev": "5602cce8dce523ac65415a36db784361d80a6074", "commit_rev":
"b5161efc5688ca9a7d45524c672b4cda02ea56ea"}
Message was sent while issue was closed.
Description was changed from ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng ========== to ========== Move c++ configs from buildtools to build/config/c++ [src-side change] This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of /buildtools/third_party/libc++:config into //build/config/c++/c++. This has several advantages: * Users can remove libc++ config if they want since it's added in BUILDCONFIG.gn * Allows removal of libcxx_proxy * libc++-specific configs are in buildtools and non-libc++ configs are in build/config * Allows changing c++ flags without having to roll buildtools * Removes a bit of duplicated build configuration buildtools change: https://codereview.chromium.org/2962423002 BUG=593874 R=thakis@chromium.org TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_ubsan_rel_ng;master.tryserver.chromium.linux:linux_chromium_dbg_ng Review-Url: https://codereview.chromium.org/2964243002 Cr-Commit-Position: refs/heads/master@{#486229} Committed: https://chromium.googlesource.com/chromium/src/+/b5161efc5688ca9a7d45524c672b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/b5161efc5688ca9a7d45524c672b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
