Move c++ configs from buildtools to build/config/c++ [buildtools-side change]

Move c++ configs from buildtools to build/config/c++ [buildtools-side change]

This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of
/buildtools/third_party/libc++:config into //build/config/c++/c++.
This has several advantages:
* Users can remove libc++ config if they want since it's added in
  BUILDCONFIG.gn
* Allows removal of libcxx_proxy
* libc++-specific configs are in buildtools and non-libc++ configs are
  in build/config
* Allows changing c++ flags without having to roll buildtools
* Removes a bit of duplicated build configuration

src-side change:
https://codereview.chromium.org/2964243002

BUG=593874
R=thakis@chromium.org

Committed: b43e28d067fa6f13bacebd4ca9d6052db1bef346

[Tom Anderson, 2017-06-30 18:54:21]

Description was changed from

==========
Move c++ configs from buildtools to build/config/c++ [buildtools-side change]

BUG=593874
R=thakis@chromium.org
==========

to

==========
Move c++ configs from buildtools to build/config/c++ [buildtools-side change]

This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of
/buildtools/third_party/libc++:config into //build/config/c++/c++.
This has several advantages:
* Users can remove libc++ config if they want since it's added in
  BUILDCONFIG.gn
* Allows removal of libcxx_proxy
* libc++-specific configs are in buildtools and non-libc++ configs are
  in build/config
* Allows changing c++ flags without having to roll buildtools
* Removes a bit of duplicated build configuration

src-side change:
https://codereview.chromium.org/2964243002

BUG=593874
R=thakis@chromium.org
==========

[Tom Anderson, 2017-06-30 18:56:35]

thakis ptal

I have this and a few other cleanups I want to do before I mark bug 593874 as
fixed.  Hopefully I can get them all done today

[Nico, 2017-06-30 20:07:04]

https://codereview.chromium.org/2962423002/diff/1/third_party/libc++/BUILD.gn
File third_party/libc++/BUILD.gn (right):

https://codereview.chromium.org/2962423002/diff/1/third_party/libc++/BUILD.gn...
third_party/libc++/BUILD.gn:51: visibility = [
"//build/config:exe_and_shlib_deps" ]
Hmm, this adds a cycling dependency between files in src.git and buildtools.git.
This tends to cause headaches down the road. If we want to do this, maybe we
should move the libc++ build files into sec/build/secondary?

...but I think they are here because v8 wants them too. This CL here would be
inconvenient for v8 too?

[Tom Anderson, 2017-06-30 21:08:28]

https://codereview.chromium.org/2962423002/diff/1/third_party/libc++/BUILD.gn
File third_party/libc++/BUILD.gn (right):

https://codereview.chromium.org/2962423002/diff/1/third_party/libc++/BUILD.gn...
third_party/libc++/BUILD.gn:51: visibility = [
"//build/config:exe_and_shlib_deps" ]
On 2017/06/30 20:07:04, Nico (vacation Jun 30-Jul 11) wrote:
> Hmm, this adds a cycling dependency between files in src.git and
buildtools.git.
> This tends to cause headaches down the road. If we want to do this, maybe we
> should move the libc++ build files into sec/build/secondary?
> 
> ...but I think they are here because v8 wants them too. This CL here would be
> inconvenient for v8 too?

Wouldn't that just require rolling buildtools at the same time as build?  I'm
not opposed to just removing the visibility addition if you think it will cause
problems.

[Michael Achenbach, 2017-07-03 06:37:56]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2017-07-03 06:37:57]

https://codereview.chromium.org/2962423002/diff/1/third_party/libc++/BUILD.gn
File third_party/libc++/BUILD.gn (right):

https://codereview.chromium.org/2962423002/diff/1/third_party/libc++/BUILD.gn...
third_party/libc++/BUILD.gn:51: visibility = [
"//build/config:exe_and_shlib_deps" ]
On 2017/06/30 21:08:28, Tom Anderson wrote:
> On 2017/06/30 20:07:04, Nico (vacation Jun 30-Jul 11) wrote:
> > Hmm, this adds a cycling dependency between files in src.git and
> buildtools.git.
> > This tends to cause headaches down the road. If we want to do this, maybe we
> > should move the libc++ build files into sec/build/secondary?
> > 
> > ...but I think they are here because v8 wants them too. This CL here would
be
> > inconvenient for v8 too?
> 
> Wouldn't that just require rolling buildtools at the same time as build?  I'm
> not opposed to just removing the visibility addition if you think it will
cause
> problems.

Our deps roller usually auto-rolls build and buildtools at the same time into
v8. So if thing's keep running with this build<>buildtools dependency, I'm not
opposed.

[Tom Anderson, 2017-07-05 18:04:27]

thomasanderson@chromium.org changed reviewers:
+ hans@chromium.org

[Tom Anderson, 2017-07-05 18:04:27]

thakis@ is OOO so +hans@

[Nico, 2017-07-05 19:20:15]

Hans is ooo too, he just didn't update his rietveld name.

Lgtm

[Nico, 2017-07-11 15:02:44]

On 2017/07/05 19:20:15, Nico (vacation Jun 30-Jul 11) wrote:
> Hans is ooo too, he just didn't update his rietveld name.
> 
> Lgtm

(I'm still a bit worried about the cycle, but it's easy enough to remove later
if it causes issues.)

[Tom Anderson, 2017-07-12 18:22:53]

Removed the visibility restriction.

[Tom Anderson, 2017-07-12 18:23:00]

Description was changed from

==========
Move c++ configs from buildtools to build/config/c++ [buildtools-side change]

This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of
/buildtools/third_party/libc++:config into //build/config/c++/c++.
This has several advantages:
* Users can remove libc++ config if they want since it's added in
  BUILDCONFIG.gn
* Allows removal of libcxx_proxy
* libc++-specific configs are in buildtools and non-libc++ configs are
  in build/config
* Allows changing c++ flags without having to roll buildtools
* Removes a bit of duplicated build configuration

src-side change:
https://codereview.chromium.org/2964243002

BUG=593874
R=thakis@chromium.org
==========

to

==========
Move c++ configs from buildtools to build/config/c++ [buildtools-side change]

This CL moves //buildtools/third_party/libc++:no_libstdcpp and part of
/buildtools/third_party/libc++:config into //build/config/c++/c++.
This has several advantages:
* Users can remove libc++ config if they want since it's added in
  BUILDCONFIG.gn
* Allows removal of libcxx_proxy
* libc++-specific configs are in buildtools and non-libc++ configs are
  in build/config
* Allows changing c++ flags without having to roll buildtools
* Removes a bit of duplicated build configuration

src-side change:
https://codereview.chromium.org/2964243002

BUG=593874
R=thakis@chromium.org

Committed: b43e28d067fa6f13bacebd4ca9d6052db1bef346
==========

[Tom Anderson, 2017-07-12 18:23:01]

Committed patchset #2 (id:20001) manually as
b43e28d067fa6f13bacebd4ca9d6052db1bef346 (presubmit successful).