Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2964193002: Revert of h264_decoder_unittests: Initial Change. (Closed)

Created:
3 years, 5 months ago by Timothy Loh
Modified:
3 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of h264_decoder_unittests: Initial Change. (patchset #11 id:240001 of https://codereview.chromium.org/2760513002/ ) Reason for revert: Broke some bots: "CommandFailedError: Failed to list tests on any device" https://build.chromium.org/p/chromium.linux/builders/Android%20Tests https://build.chromium.org/p/chromium.android/builders/Android%20N5X%20Swarm%20Builder Added tests all fail: https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests Original issue's description: > h264_decoder_unittests: Initial Change. > > BUG=b/35934865 > TEST=Run the test on CrOS devices. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2760513002 > Cr-Commit-Position: refs/heads/master@{#483623} > Committed: https://chromium.googlesource.com/chromium/src/+/0fc85fd05e9607d8d1ca242b831abee0e4f4c318 TBR=dalecurtis@chromium.org,johnylin@chromium.org,kcwu@chromium.org,posciak@chromium.org,owenlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/35934865 Review-Url: https://codereview.chromium.org/2964193002 Cr-Commit-Position: refs/heads/master@{#483639} Committed: https://chromium.googlesource.com/chromium/src/+/a220b092cb4cbf7569ebe9888a5bf73df9d443a5

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
Timothy Loh
Created Revert of h264_decoder_unittests: Initial Change.
3 years, 5 months ago (2017-06-30 05:24:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964193002/1
3 years, 5 months ago (2017-06-30 05:25:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/a220b092cb4cbf7569ebe9888a5bf73df9d443a5
3 years, 5 months ago (2017-06-30 05:25:40 UTC) #6
chromium-reviews
Thank you for reverting the CL. Sorry about that. Will look into those failures. On ...
3 years, 5 months ago (2017-06-30 07:08:46 UTC) #7
Owen Lin
3 years, 5 months ago (2017-07-07 08:41:57 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2972183002/ by owenlin@chromium.org.

The reason for reverting is: The failure has been fixed in h264_decoder.
https://chromium-review.googlesource.com/c/558168/.

Powered by Google App Engine
This is Rietveld 408576698