Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 2760513002: h264_decoder_unittests: Initial Change.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Owen Lin
Modified:
2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

h264_decoder_unittests: Initial Change. BUG=b/35934865 TEST=Run the test on CrOS devices. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address kcwu's comments #

Patch Set 3 : incliude binary files #

Patch Set 4 : Fix build issue on win_clang #

Total comments: 2

Patch Set 5 : Address kcwu's comments. #

Total comments: 17
Unified diffs Side-by-side diffs Delta from patch set Stats (+416 lines, -20 lines) Patch
M media/BUILD.gn View 1 1 chunk +1 line, -10 lines 0 comments Download
M media/gpu/BUILD.gn View 1 2 3 4 4 chunks +28 lines, -9 lines 0 comments Download
A media/gpu/h264_decoder_unittest.cc View 1 2 3 4 1 chunk +385 lines, -0 lines 17 comments Download
M media/gpu/h264_dpb.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
A media/test/data/bear-320x192-baseline-frame-0.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-baseline-frame-1.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-baseline-frame-2.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-baseline-frame-3.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-high-frame-0.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-high-frame-1.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-high-frame-2.h264 View 1 2 Binary file 0 comments Download
A media/test/data/bear-320x192-high-frame-3.h264 View 1 2 Binary file 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 25 (15 generated)
Owen Lin
PTAL. Thanks.
2 months, 1 week ago (2017-03-17 03:03:47 UTC) #3
kcwu
https://codereview.chromium.org/2760513002/diff/1/media/gpu/BUILD.gn File media/gpu/BUILD.gn (right): https://codereview.chromium.org/2760513002/diff/1/media/gpu/BUILD.gn#newcode526 media/gpu/BUILD.gn:526: if (is_chromeos || is_win) { Is it possible to ...
2 months, 1 week ago (2017-03-17 06:47:44 UTC) #4
Owen Lin
Please take another look, thanks. https://codereview.chromium.org/2760513002/diff/1/media/gpu/BUILD.gn File media/gpu/BUILD.gn (right): https://codereview.chromium.org/2760513002/diff/1/media/gpu/BUILD.gn#newcode526 media/gpu/BUILD.gn:526: if (is_chromeos || is_win) ...
2 months, 1 week ago (2017-03-20 08:00:05 UTC) #10
kcwu
https://codereview.chromium.org/2760513002/diff/1/media/gpu/h264_decoder_unittest.cc File media/gpu/h264_decoder_unittest.cc (right): https://codereview.chromium.org/2760513002/diff/1/media/gpu/h264_decoder_unittest.cc#newcode251 media/gpu/h264_decoder_unittest.cc:251: ASSERT_EQ(0u, expected_events_.size()); On 2017/03/20 08:00:04, Owen Lin wrote: > ...
2 months, 1 week ago (2017-03-20 08:28:09 UTC) #11
Owen Lin
https://codereview.chromium.org/2760513002/diff/1/media/gpu/h264_decoder_unittest.cc File media/gpu/h264_decoder_unittest.cc (right): https://codereview.chromium.org/2760513002/diff/1/media/gpu/h264_decoder_unittest.cc#newcode251 media/gpu/h264_decoder_unittest.cc:251: ASSERT_EQ(0u, expected_events_.size()); On 2017/03/20 08:28:09, kcwu wrote: > On ...
2 months, 1 week ago (2017-03-20 09:29:27 UTC) #13
kcwu
lgtm
2 months, 1 week ago (2017-03-20 09:32:58 UTC) #14
Owen Lin
PTAL. Thank you.
2 months ago (2017-03-21 02:02:57 UTC) #20
DaleCurtis
lgtm https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder_unittest.cc File media/gpu/h264_decoder_unittest.cc (right): https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder_unittest.cc#newcode86 media/gpu/h264_decoder_unittest.cc:86: size_t GetNumberOfExpectedEvents() const { return expected_events_.size(); } Inline ...
2 months ago (2017-03-21 18:07:18 UTC) #21
Pawel Osciak
https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder_unittest.cc File media/gpu/h264_decoder_unittest.cc (right): https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder_unittest.cc#newcode23 media/gpu/h264_decoder_unittest.cc:23: const char* kBaselineFrame0 = "bear-320x192-baseline-frame-0.h264"; Perhaps const std::string, as ...
2 months ago (2017-03-23 08:34:21 UTC) #24
kcwu
2 months ago (2017-03-23 08:54:33 UTC) #25
https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder...
File media/gpu/h264_decoder_unittest.cc (right):

https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder...
media/gpu/h264_decoder_unittest.cc:254: EXPECT_EQ(decoder_->GetPicSize(),
gfx::Size(320, 192));
Please swap the arguments.
They are read as EXPECT_*(expect, actual);

https://codereview.chromium.org/2760513002/diff/120001/media/gpu/h264_decoder...
media/gpu/h264_decoder_unittest.cc:272: EXPECT_EQ(decoder_->GetPicSize(),
gfx::Size(320, 192));
Please swap the arguments.
They are read as EXPECT_*(expect, actual);
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06