Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime

Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime

This CL also removes some compiler flags that increase space somewhat
that help the profiler find symbols, which isn't included in a PRODUCT
build.

Before:
zra@zach:~/dart/sdk$ ls -la out/ProductX64/exe.stripped/
-rwxr-x--- 1 zra eng  9693064 Jun 29 14:52 dart
-rwxr-x--- 1 zra eng  7391080 Jun 29 14:52 dart_precompiled_runtime

R=askesc@google.com, rmacnak@google.com

After:
-rwxr-x--- 1 zra eng  6809424 Jun 29 15:11 dart
-rwxr-x--- 1 zra eng  3299120 Jun 29 15:11 dart_precompiled_runtime
Committed: https://github.com/dart-lang/sdk/commit/1a8174b08d727c6b6fc5d4c324aab94c7285f39a

[zra, 2017-06-29 23:53:01]

Description was changed from

==========
Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime

This CL also removes some compiler flags that increase space somewhat
that help the profiler find symbols, which isn't included in a PRODUCT
build.
==========

to

==========
Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime

This CL also removes some compiler flags that increase space somewhat
that help the profiler find symbols, which isn't included in a PRODUCT
build.

Before:
zra@zach:~/dart/sdk$ ls -la out/ProductX64/exe.stripped/
-rwxr-x--- 1 zra eng  9693064 Jun 29 14:52 dart
-rwxr-x--- 1 zra eng  7391080 Jun 29 14:52 dart_precompiled_runtime

After:
-rwxr-x--- 1 zra eng  6809424 Jun 29 15:11 dart
-rwxr-x--- 1 zra eng  3299120 Jun 29 15:11 dart_precompiled_runtime
==========

[zra, 2017-06-29 23:53:34]

zra@google.com changed reviewers:
+ askesc@google.com, rmacnak@google.com

[rmacnak, 2017-06-30 00:38:00]

lgtm

https://codereview.chromium.org/2964133002/diff/1/runtime/runtime_args.gni
File runtime/runtime_args.gni (right):

https://codereview.chromium.org/2964133002/diff/1/runtime/runtime_args.gni#ne...
runtime/runtime_args.gni:11: # Set the runtime mode. This affects how the
runtime is built and what
TODO(rmacnak): dart_runtime_mode no longer selects whether libdart is build for
JIT or AOT, since libdart with split into libdart_jit and
libdart_precompiled_runtime. We should remove this flag and just set
dart_debug/dart_product.

https://codereview.chromium.org/2964133002/diff/1/runtime/runtime_args.gni#ne...
runtime/runtime_args.gni:27: # Available options are: arm, arm64, x64, and ia32
dbc

[Aske Simon Christensen, 2017-06-30 10:25:27]

I am not familiar with the build system, but lgtm.

[zra, 2017-06-30 14:55:46]

https://codereview.chromium.org/2964133002/diff/1/runtime/runtime_args.gni
File runtime/runtime_args.gni (right):

https://codereview.chromium.org/2964133002/diff/1/runtime/runtime_args.gni#ne...
runtime/runtime_args.gni:11: # Set the runtime mode. This affects how the
runtime is built and what
On 2017/06/30 00:38:00, rmacnak wrote:
> TODO(rmacnak): dart_runtime_mode no longer selects whether libdart is build
for
> JIT or AOT, since libdart with split into libdart_jit and
> libdart_precompiled_runtime. We should remove this flag and just set
> dart_debug/dart_product.

Done.

https://codereview.chromium.org/2964133002/diff/1/runtime/runtime_args.gni#ne...
runtime/runtime_args.gni:27: # Available options are: arm, arm64, x64, and ia32
On 2017/06/30 00:38:00, rmacnak wrote:
> dbc

Done.

[zra, 2017-06-30 15:09:41]

Description was changed from

==========
Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime

This CL also removes some compiler flags that increase space somewhat
that help the profiler find symbols, which isn't included in a PRODUCT
build.

Before:
zra@zach:~/dart/sdk$ ls -la out/ProductX64/exe.stripped/
-rwxr-x--- 1 zra eng  9693064 Jun 29 14:52 dart
-rwxr-x--- 1 zra eng  7391080 Jun 29 14:52 dart_precompiled_runtime

After:
-rwxr-x--- 1 zra eng  6809424 Jun 29 15:11 dart
-rwxr-x--- 1 zra eng  3299120 Jun 29 15:11 dart_precompiled_runtime
==========

to

==========
Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime

This CL also removes some compiler flags that increase space somewhat
that help the profiler find symbols, which isn't included in a PRODUCT
build.

Before:
zra@zach:~/dart/sdk$ ls -la out/ProductX64/exe.stripped/
-rwxr-x--- 1 zra eng  9693064 Jun 29 14:52 dart
-rwxr-x--- 1 zra eng  7391080 Jun 29 14:52 dart_precompiled_runtime

R=askesc@google.com, rmacnak@google.com

After:
-rwxr-x--- 1 zra eng  6809424 Jun 29 15:11 dart
-rwxr-x--- 1 zra eng  3299120 Jun 29 15:11 dart_precompiled_runtime
Committed:
https://github.com/dart-lang/sdk/commit/1a8174b08d727c6b6fc5d4c324aab94c7285f39a
==========

[zra, 2017-06-30 15:09:42]

Committed patchset #2 (id:20001) manually as
1a8174b08d727c6b6fc5d4c324aab94c7285f39a (presubmit successful).