Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: runtime/runtime_args.gni

Issue 2964133002: Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime (Closed)
Patch Set: Addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | third_party/tcmalloc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/runtime_args.gni
diff --git a/runtime/runtime_args.gni b/runtime/runtime_args.gni
index 750c2b4346b3dab460770e9b4c667f1d738f7d60..d3f4710abf2b729dc31df85520b41cc02fc7fbd9 100644
--- a/runtime/runtime_args.gni
+++ b/runtime/runtime_args.gni
@@ -3,6 +3,38 @@
# BSD-style license that can be found in the LICENSE file.
declare_args() {
+ # Instead of using is_debug, we introduce a different flag for specifying a
+ # Debug build of Dart so that clients can still use a Release build of Dart
+ # while themselves doing a Debug build.
+ dart_debug = false
+
+ # Set the runtime mode. This affects how the runtime is built and what
+ # features it has. Valid values are:
+ # 'develop' (the default) - VM is built to run as a JIT with all development
+ # features enabled.
+ # 'profile' - The VM is built to run with AOT compiled code with only the
+ # CPU profiling features enabled.
+ # 'release' - The VM is built to run with AOT compiled code with no developer
+ # features enabled.
+ #
+ # These settings are only used for Flutter, at the moment. A standalone build
+ # of the Dart VM should leave this set to "develop", and should set
+ # 'is_debug', 'is_release', or 'is_product'.
+ #
+ # TODO(rmacnak): dart_runtime_mode no longer selects whether libdart is build
+ # for JIT or AOT, since libdart waw split into libdart_jit and
+ # libdart_precompiled_runtime. We should remove this flag and just set
+ # dart_debug/dart_product.
+ dart_runtime_mode = "develop"
+
+ # Explicitly set the target architecture in case of precompilation. Leaving
+ # this unspecified results in automatic target architecture detection.
+ # Available options are: arm, arm64, x64, ia32, and dbc.
+ dart_target_arch = ""
+
+ # The optimization level to use for debug builds.
+ dart_debug_optimization_level = "2"
+
# Whether to fall back to built-in root certificates when they cannot be
# verified at the operating system level.
dart_use_fallback_root_certificates = false
« no previous file with comments | « runtime/bin/vmservice_impl.cc ('k') | third_party/tcmalloc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698