Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/tcmalloc/BUILD.gn

Issue 2964133002: Exclude Observatory assets from PRODUCT build dart, dart_precompiled_runtime (Closed)
Patch Set: Addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/runtime_args.gni ('k') | tools/gn.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/tcmalloc/BUILD.gn
diff --git a/third_party/tcmalloc/BUILD.gn b/third_party/tcmalloc/BUILD.gn
index 09d69a982abcd19cad67fcbccf231761b13d5ace..c1b9f102ed4a7d915e9063a5f4b9cafde3bee1e3 100644
--- a/third_party/tcmalloc/BUILD.gn
+++ b/third_party/tcmalloc/BUILD.gn
@@ -92,9 +92,12 @@ source_set("tcmalloc") {
"NDEBUG",
]
- # Disable stack sampling for heap profiling in Product builds.
if (is_product) {
+ # Disable stack sampling for heap profiling in Product builds.
defines += [ "NO_TCMALLOC_SAMPLES" ]
+
+ # To override the C library functions, we can't hide symbols.
+ configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
}
cflags = [
« no previous file with comments | « runtime/runtime_args.gni ('k') | tools/gn.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698