Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2964033002: Disable cross-process navigations in --single-process. (Closed)

Created:
3 years, 5 months ago by Charlie Reis
Modified:
3 years, 5 months ago
Reviewers:
kenrb, alexmos
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, site-isolation-reviews_chromium.org, ncarter (slow)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable cross-process navigations in --single-process. This flag takes precedence over --site-per-process and other site isolation modes. BUG=688617 TEST=Cross-site subframes work with --single-process --site-per-process CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2964033002 Cr-Commit-Position: refs/heads/master@{#485292} Committed: https://chromium.googlesource.com/chromium/src/+/0b49fa16f0265a0b1274383546fe933c288d2106

Patch Set 1 #

Patch Set 2 : Don't lock to origin #

Patch Set 3 : Fix condition. #

Total comments: 5

Patch Set 4 : Only update --site-per-process #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M content/browser/frame_host/render_frame_host_manager.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 1 chunk +3 lines, -23 lines 0 comments Download
M content/browser/site_instance_impl.cc View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (20 generated)
Charlie Reis
Alex, can you take a look? Hopefully this updated version should pass the try jobs. ...
3 years, 5 months ago (2017-06-29 22:41:48 UTC) #10
alexmos
Thanks! I think this makes sense, but a few sanity checks about process-per-tab below. https://codereview.chromium.org/2964033002/diff/40001/content/browser/frame_host/render_frame_host_manager.cc ...
3 years, 5 months ago (2017-06-30 02:23:29 UTC) #13
alexmos
https://codereview.chromium.org/2964033002/diff/40001/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://codereview.chromium.org/2964033002/diff/40001/content/browser/frame_host/render_frame_host_manager.cc#newcode1078 content/browser/frame_host/render_frame_host_manager.cc:1078: bool RenderFrameHostManager::ShouldTransitionCrossSite() { Just noticed that the comment for ...
3 years, 5 months ago (2017-06-30 20:40:38 UTC) #14
Charlie Reis
https://codereview.chromium.org/2964033002/diff/40001/content/browser/frame_host/render_frame_host_manager.cc File content/browser/frame_host/render_frame_host_manager.cc (right): https://codereview.chromium.org/2964033002/diff/40001/content/browser/frame_host/render_frame_host_manager.cc#newcode1083 content/browser/frame_host/render_frame_host_manager.cc:1083: // within a tab.) On 2017/06/30 20:40:38, alexmos wrote: ...
3 years, 5 months ago (2017-06-30 23:45:15 UTC) #16
Charlie Reis
Thanks for the feedback! I've limited this CL to only affect --site-per-process mode for now, ...
3 years, 5 months ago (2017-07-10 16:18:38 UTC) #22
alexmos
Thanks, LGTM!
3 years, 5 months ago (2017-07-10 16:25:19 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2964033002/60001
3 years, 5 months ago (2017-07-10 16:26:25 UTC) #25
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 16:31:31 UTC) #28
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0b49fa16f0265a0b1274383546fe...

Powered by Google App Engine
This is Rietveld 408576698