Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2968753003: Don't use --process-per-tab when running layout tests. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 5 months ago
Reviewers:
alexmos
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use --process-per-tab when running layout tests. 1. RenderFrameHostManager::ShouldTransitionCrossSite first checks SiteIsolationPolicy::AreCrossProcessFramesPossible() and if it is true, then switches::kProcessPerTab is ignored. 2. SiteIsolationPolicy::AreCrossProcessFramesPossible() returns true on all platforms except Android since r448761 which initially landed in 58.0.3006.0 1 and 2 taken together mean that --process-per-tab switch is a no-op on all platforms except Android. This has been the case for the last 2 milestones. Therefore let's stop using the no-op switch when running layout tests. BUG=477150 Review-Url: https://codereview.chromium.org/2968753003 Cr-Commit-Position: refs/heads/master@{#483809} Committed: https://chromium.googlesource.com/chromium/src/+/b3b4f35a6de19f1fe00f086a19ec7572e231e5d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M content/shell/app/shell_main_delegate.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Łukasz Anforowicz
Alex, can you PTAL?
3 years, 5 months ago (2017-06-30 19:44:52 UTC) #6
Łukasz Anforowicz
+site-isolation-reviews@chromium.org
3 years, 5 months ago (2017-06-30 19:47:30 UTC) #7
alexmos
LGTM!
3 years, 5 months ago (2017-06-30 20:34:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2968753003/1
3 years, 5 months ago (2017-06-30 20:39:48 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 20:44:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b3b4f35a6de19f1fe00f086a19ec...

Powered by Google App Engine
This is Rietveld 408576698