Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2963893002: [ui] Adds a browser_tests hook to show ZoomBubbleView (Closed)

Created:
3 years, 5 months ago by varkha
Modified:
3 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ui] Adds a browser_tests hook to show ZoomBubbleView To show the dialog use: browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive --dialog=ZoomBubbleDialogTest.InvokeDialog_default BUG=651641 Review-Url: https://codereview.chromium.org/2963893002 Cr-Commit-Position: refs/heads/master@{#483270} Committed: https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d2ebdd351882e

Patch Set 1 #

Total comments: 2

Patch Set 2 : [ui] Adds a browser_tests hook to show ZoomBubbleView (no command line) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
varkha
pkasting@, can you please take a look? Thanks!
3 years, 5 months ago (2017-06-29 01:02:51 UTC) #4
Peter Kasting
LGTM save one thing https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc File chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc (right): https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc#newcode91 chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc:91: command_line->AppendSwitch(switches::kExtendMdToSecondaryUi); Why this line? Seems ...
3 years, 5 months ago (2017-06-29 01:07:26 UTC) #5
varkha
Thanks! https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc File chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc (right): https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc#newcode91 chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc:91: command_line->AppendSwitch(switches::kExtendMdToSecondaryUi); On 2017/06/29 01:07:26, Peter Kasting wrote: > ...
3 years, 5 months ago (2017-06-29 01:14:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963893002/40001
3 years, 5 months ago (2017-06-29 01:15:06 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 02:57:24 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d...

Powered by Google App Engine
This is Rietveld 408576698