[ui] Adds a browser_tests hook to show ZoomBubbleView

[ui] Adds a browser_tests hook to show ZoomBubbleView

To show the dialog use:
browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
 --dialog=ZoomBubbleDialogTest.InvokeDialog_default

BUG=651641
Review-Url: https://codereview.chromium.org/2963893002
Cr-Commit-Position: refs/heads/master@{#483270}
Committed: https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d2ebdd351882e

[varkha, 2017-06-29 01:00:56]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 01:01:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2017-06-29 01:02:51]

varkha@chromium.org changed reviewers:
+ pkasting@chromium.org

[varkha, 2017-06-29 01:02:51]

pkasting@, can you please take a look? Thanks!

[Peter Kasting, 2017-06-29 01:07:26]

LGTM save one thing

https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc:91:
command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
Why this line?  Seems like you want to test the dialog in whichever state the
user specifies.

[varkha, 2017-06-29 01:13:55]

Patchset #2 (id:20001) has been deleted

[varkha, 2017-06-29 01:14:36]

Thanks!

https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/loc...
File chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc
(right):

https://codereview.chromium.org/2963893002/diff/1/chrome/browser/ui/views/loc...
chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc:91:
command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);
On 2017/06/29 01:07:26, Peter Kasting wrote:
> Why this line?  Seems like you want to test the dialog in whichever state the
> user specifies.

Looked at a couple examples that are doing this so I thought it would be useful.
It is easy to launch the test with this in command line so removing.

[varkha, 2017-06-29 01:14:55]

The CQ bit was checked by varkha@chromium.org

[varkha, 2017-06-29 01:14:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2963893002/#ps40001
(title: "[ui] Adds a browser_tests hook to show ZoomBubbleView (no command
line)")

[commit-bot: I haz the power, 2017-06-29 01:15:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 02:57:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498698895802860,
"parent_rev": "0edf32054bc4767088e835e9bc54ed61876bb331", "commit_rev":
"8a857186d00beb74ffb1ebb6870d2ebdd351882e"}

[commit-bot: I haz the power, 2017-06-29 02:57:23]

Description was changed from

==========
[ui] Adds a browser_tests hook to show ZoomBubbleView

To show the dialog use:
browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
 --dialog=ZoomBubbleDialogTest.InvokeDialog_default

BUG=635173
==========

to

==========
[ui] Adds a browser_tests hook to show ZoomBubbleView

To show the dialog use:
browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
 --dialog=ZoomBubbleDialogTest.InvokeDialog_default

BUG=635173

Review-Url: https://codereview.chromium.org/2963893002
Cr-Commit-Position: refs/heads/master@{#483270}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d...
==========

[commit-bot: I haz the power, 2017-06-29 02:57:24]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d...

[varkha, 2017-06-29 03:30:59]

Description was changed from

==========
[ui] Adds a browser_tests hook to show ZoomBubbleView

To show the dialog use:
browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
 --dialog=ZoomBubbleDialogTest.InvokeDialog_default

BUG=635173

Review-Url: https://codereview.chromium.org/2963893002
Cr-Commit-Position: refs/heads/master@{#483270}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d...
==========

to

==========
[ui] Adds a browser_tests hook to show ZoomBubbleView

To show the dialog use:
browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
 --dialog=ZoomBubbleDialogTest.InvokeDialog_default

BUG=651641

Review-Url: https://codereview.chromium.org/2963893002
Cr-Commit-Position: refs/heads/master@{#483270}
Committed:
https://chromium.googlesource.com/chromium/src/+/8a857186d00beb74ffb1ebb6870d...
==========