[ui] Adds a browser_tests hook to show ZoomBubbleView

chrome/browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/location_bar/zoom_bubble_view.h"
 
+#include "base/command_line.h"
 #include "build/build_config.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller.h"
 #include "chrome/browser/ui/exclusive_access/fullscreen_controller_test.h"
+#include "chrome/browser/ui/test/test_browser_dialog.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/immersive_mode_controller.h"
 #include "chrome/test/base/in_process_browser_test.h"
+#include "ui/base/ui_base_switches.h"
 
 typedef InProcessBrowserTest ZoomBubbleBrowserTest;
 
 #if defined(USE_ASH)
 #include "ash/test/immersive_fullscreen_controller_test_api.h"
 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"
 #endif
 
 // TODO(linux_aura) http://crbug.com/163931
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA)
@@ skipping 40 matching lines @@
 
   // Exit fullscreen before ending the test for the sake of sanity.
   {
     std::unique_ptr<FullscreenNotificationObserver> waiter(
         new FullscreenNotificationObserver());
     chrome::ToggleFullscreenMode(browser());
     waiter->Wait();
   }
 }
 
+class ZoomBubbleDialogTest : public DialogBrowserTest {
+ public:
+  ZoomBubbleDialogTest() {}
+
+  // DialogBrowserTest:
+  void ShowDialog(const std::string& name) override {
+    BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
+    content::WebContents* web_contents = browser_view->GetActiveWebContents();
+    ZoomBubbleView::ShowBubble(web_contents, gfx::Point(),
+                               ZoomBubbleView::USER_GESTURE);
+  }
+
+  // content::BrowserTestBase:
+  void SetUpCommandLine(base::CommandLine* command_line) override {
+    command_line->AppendSwitch(switches::kExtendMdToSecondaryUi);

[Peter Kasting, 2017/06/29 01:07:26]

Why this line?  Seems like you want to test the dialog in whichever state the
user specifies.

[varkha, 2017/06/29 01:14:36]

Looked at a couple examples that are doing this so I thought it would be useful.
It is easy to launch the test with this in command line so removing.

+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ZoomBubbleDialogTest);
+};
+
+// Test that calls ShowDialog("default"). Interactive when run via
+// browser_tests --gtest_filter=BrowserDialogTest.Invoke --interactive
+// --dialog=ZoomBubbleDialogTest.InvokeDialog_default
+IN_PROC_BROWSER_TEST_F(ZoomBubbleDialogTest, InvokeDialog_default) {
+  RunDialog();
+}
+
 // TODO(zturner): Change this to USE_ASH after fixing the test on Windows.
 #if defined(OS_CHROMEOS)
 // Test whether the zoom bubble is anchored and whether it is visible when in
 // immersive fullscreen.
 IN_PROC_BROWSER_TEST_F(ZoomBubbleBrowserTest, ImmersiveFullscreen) {
   BrowserView* browser_view = static_cast<BrowserView*>(browser()->window());
   content::WebContents* web_contents = browser_view->GetActiveWebContents();
 
   ImmersiveModeController* immersive_controller =
       browser_view->immersive_mode_controller();
@@ skipping 48 matching lines @@
 
   // Exit fullscreen before ending the test for the sake of sanity.
   {
     std::unique_ptr<FullscreenNotificationObserver> waiter(
         new FullscreenNotificationObserver());
     chrome::ToggleFullscreenMode(browser());
     waiter->Wait();
   }
 }
 #endif  // OS_CHROMEOS