Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2963843002: Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (Closed)

Created:
3 years, 5 months ago by engedy
Modified:
3 years, 5 months ago
Reviewers:
Dirk Pranke, erikchen
CC:
chromium-reviews, mac-reviews_chromium.org, justincohen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #2 id:20001 of https://codereview.chromium.org/2950933003/ ) Reason for revert: Broke try bot: mac_chromium_10.10_rel_ng https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.10_rel_ng?numbuilds=100 Original issue's description: > mac: Roll hermetic toolchain to Xcode 8.3.2. > > Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the > 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. > > To support machines running macOS versions < 10.12, but don't require building > targets, this CL also: > * Does not download the hermetic toolchain if the macOS version does not > support the toolchain version. > * Does not allow building targets with the default hermetic toolchain if the > macOS version does not support the toolchain version. > > BUG=624049 > > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Original-Original-Commit-Position: refs/heads/master@{#481225} > Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Original-Commit-Position: refs/heads/master@{#481692} > Committed: https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea5719890e7af365 > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Commit-Position: refs/heads/master@{#482776} > Committed: https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8cb0a1b1dba087 TBR=dpranke@chromium.org,erikchen@chromium.org # Done partial CQ checks because original CL landed almost 1 days ago. NOTREECHECKS=true NOPRESUBMIT=true NOTREECHECKS=true BUG=624049 Review-Url: https://codereview.chromium.org/2963843002 Cr-Commit-Position: refs/heads/master@{#483120} Committed: https://chromium.googlesource.com/chromium/src/+/8bf722464b7361247ffaada42c179c6912c4125d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
M build/mac/should_use_hermetic_xcode.py View 3 chunks +2 lines, -13 lines 0 comments Download
M build/mac_toolchain.py View 4 chunks +1 line, -17 lines 0 comments Download
M build_overrides/build.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
engedy
Created Revert of mac: Roll hermetic toolchain to Xcode 8.3.2.
3 years, 5 months ago (2017-06-28 18:27:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963843002/1
3 years, 5 months ago (2017-06-28 18:31:28 UTC) #5
engedy
Okay, at least one bot per platform past analyze, including Mac 10.10. Landing this now ...
3 years, 5 months ago (2017-06-28 18:49:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963843002/1
3 years, 5 months ago (2017-06-28 18:50:19 UTC) #10
Dirk Pranke
lgtm
3 years, 5 months ago (2017-06-28 19:42:08 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 20:34:39 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8bf722464b7361247ffaada42c17...

Powered by Google App Engine
This is Rietveld 408576698