mac: Roll hermetic toolchain to Xcode 8.3.2.

mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#481225}
Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Commit-Position: refs/heads/master@{#481692}
Committed: https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea5719890e7af365
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#482776}
Committed: https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8cb0a1b1dba087
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#483217}
Committed: https://chromium.googlesource.com/chromium/src/+/d5dfcdb0f4ef632fc90a53e02796f72d8d81f657

[erikchen, 2017-06-21 01:37:23]

erikchen@chromium.org changed reviewers:
+ dpranke@chromium.org

[erikchen, 2017-06-21 01:37:24]

dpranke: Please review.

[Dirk Pranke, 2017-06-21 01:55:21]

lgtm

[erikchen, 2017-06-21 02:29:26]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 02:29:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 04:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 04:09:55]

Dry run: This issue passed the CQ dry run.

[erikchen, 2017-06-21 16:58:49]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-06-21 16:59:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 17:03:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498064329219260,
"parent_rev": "aec4b616ab0ec19a7aa7e1af100ceef75dde5285", "commit_rev":
"2f19b143e444c920e643feda583e9ceb72d29c8e"}

[commit-bot: I haz the power, 2017-06-21 17:03:16]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
==========

[commit-bot: I haz the power, 2017-06-21 17:03:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...

[martiniss, 2017-06-21 18:10:48]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2949043002/ by martiniss@chromium.org.

The reason for reverting is: Broke mac builders on chromium.perf:
https://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/102244.

[erikchen, 2017-06-22 20:45:19]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
==========

[erikchen, 2017-06-22 20:45:28]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-06-22 20:45:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 22:23:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498164328608520,
"parent_rev": "0070d4146866230c1a5599be3444794ee72d47ae", "commit_rev":
"350127923178be13e901e047ea5719890e7af365"}

[commit-bot: I haz the power, 2017-06-22 22:24:07]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
==========

[commit-bot: I haz the power, 2017-06-22 22:24:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...

[erikchen, 2017-06-23 00:07:10]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2957483002/ by erikchen@chromium.org.

The reason for reverting is: Reverting. Failed to update all perf Mac Builder
slaves to 10.12..

[erikchen, 2017-06-27 20:37:57]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
==========

[erikchen, 2017-06-27 20:38:14]

On 2017/06/23 00:07:10, erikchen wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2957483002/ by mailto:erikchen@chromium.org.
> 
> The reason for reverting is: Reverting. Failed to update all perf Mac Builder
> slaves to 10.12..

Perf builders have all been updated. Re-landing.
https://bugs.chromium.org/p/chromium/issues/detail?id=736385#c7

[erikchen, 2017-06-27 20:38:18]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-06-27 20:38:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-27 22:52:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498595898998050,
"parent_rev": "66e83f98ea40b14b29839f2044875129173289b5", "commit_rev":
"87de017dbe9a09bf33e34e462f8cb0a1b1dba087"}

[commit-bot: I haz the power, 2017-06-27 22:53:05]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#482776}
Committed:
https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8c...
==========

[commit-bot: I haz the power, 2017-06-27 22:53:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8c...

[engedy, 2017-06-28 18:27:33]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2963843002/ by engedy@chromium.org.

The reason for reverting is: Broke try bot: mac_chromium_10.10_rel_ng

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.....

[erikchen, 2017-06-28 21:47:24]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#482776}
Committed:
https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8c...
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#482776}
Committed:
https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8c...
==========

[erikchen, 2017-06-28 21:47:50]

On 2017/06/28 18:27:33, engedy wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2963843002/ by mailto:engedy@chromium.org.
> 
> The reason for reverting is: Broke try bot: mac_chromium_10.10_rel_ng
> 
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_10.....

10.10 try bots have been turned down:
https://bugs.chromium.org/p/chromium/issues/detail?id=737683

Relanding.

[erikchen, 2017-06-28 21:47:58]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2017-06-28 21:48:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 00:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498686478547360,
"parent_rev": "26082b4da5fbea8e605ff956bd5d27954c372cf0", "commit_rev":
"d5dfcdb0f4ef632fc90a53e02796f72d8d81f657"}

[commit-bot: I haz the power, 2017-06-29 00:23:08]

Description was changed from

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#482776}
Committed:
https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8c...
==========

to

==========
mac: Roll hermetic toolchain to Xcode 8.3.2.

Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the
10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK.

To support machines running macOS versions < 10.12, but don't require building
targets, this CL also:
  * Does not download the hermetic toolchain if the macOS version does not
    support the toolchain version.
  * Does not allow building targets with the default hermetic toolchain if the
    macOS version does not support the toolchain version.

BUG=624049

Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#481225}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Original-Commit-Position: refs/heads/master@{#481692}
Committed:
https://chromium.googlesource.com/chromium/src/+/350127923178be13e901e047ea57...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Original-Commit-Position: refs/heads/master@{#482776}
Committed:
https://chromium.googlesource.com/chromium/src/+/87de017dbe9a09bf33e34e462f8c...
Review-Url: https://codereview.chromium.org/2950933003
Cr-Commit-Position: refs/heads/master@{#483217}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5dfcdb0f4ef632fc90a53e02796...
==========

[commit-bot: I haz the power, 2017-06-29 00:23:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d5dfcdb0f4ef632fc90a53e02796...