NetworkService: Destroy NetworkContexts on NetworkService teardown.

NetworkService: Destroy NetworkContexts on NetworkService teardown.

Also fix NetworkContexts potentially not being destroyed on connection
error / consumer teardown, due to calling str::move twice on the same
RequestPtr.

This is a reland of https://codereview.chromium.org/2962693002,
which was reverted in https://codereview.chromium.org/2960843005/ due
to a conflict with https://codereview.chromium.org/2951813002/. The
solution was to add a base::test::ScopedTaskEnvironment to the tests.

BUG=736472
Review-Url: https://codereview.chromium.org/2963823002
Cr-Commit-Position: refs/heads/master@{#483225}
Committed: https://chromium.googlesource.com/chromium/src/+/502a6133a5974683b23edab936d6b480dcd7684e

[mmenke, 2017-06-28 18:22:14]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 18:22:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 18:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:36:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-06-28 18:37:45]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 18:38:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-28 18:47:13]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-06-28 18:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 18:52:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-06-28 19:24:42]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 19:25:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-06-28 19:51:03]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-06-28 21:57:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 21:57:30]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-06-28 22:26:34]

mmenke@chromium.org changed reviewers:
+ jam@chromium.org

[mmenke, 2017-06-28 22:26:34]

First patch set is the original CL, second is with the fix.  The failure was a
conflict with another CL I landed at the same time, so trybots would have caught
the failure if there were still an issue.

[jam, 2017-06-29 00:16:58]

lgtm

[mmenke, 2017-06-29 00:27:27]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-06-29 00:28:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 00:36:32]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498696047252760,
"parent_rev": "10e7c51706f5f386878ce5fa576fe3fffca02258", "commit_rev":
"502a6133a5974683b23edab936d6b480dcd7684e"}

[commit-bot: I haz the power, 2017-06-29 00:36:45]

Description was changed from

==========
NetworkService: Destroy NetworkContexts on NetworkService teardown.

Also fix NetworkContexts potentially not being destroyed on connection
error / consumer teardown, due to calling str::move twice on the same
RequestPtr.

This is a reland of https://codereview.chromium.org/2962693002,
which was reverted in https://codereview.chromium.org/2960843005/ due
to a conflict with https://codereview.chromium.org/2951813002/. The
solution was to add a base::test::ScopedTaskEnvironment to the tests.

BUG=736472
==========

to

==========
NetworkService: Destroy NetworkContexts on NetworkService teardown.

Also fix NetworkContexts potentially not being destroyed on connection
error / consumer teardown, due to calling str::move twice on the same
RequestPtr.

This is a reland of https://codereview.chromium.org/2962693002,
which was reverted in https://codereview.chromium.org/2960843005/ due
to a conflict with https://codereview.chromium.org/2951813002/. The
solution was to add a base::test::ScopedTaskEnvironment to the tests.

BUG=736472

Review-Url: https://codereview.chromium.org/2963823002
Cr-Commit-Position: refs/heads/master@{#483225}
Committed:
https://chromium.googlesource.com/chromium/src/+/502a6133a5974683b23edab936d6...
==========

[commit-bot: I haz the power, 2017-06-29 00:36:48]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/502a6133a5974683b23edab936d6...