Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2960843005: Revert of NetworkService: Destroy NetworkContexts on NetworkService teardown. (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, asanka, jam, kinuko, darin-cc_chromium.org, rdsmith+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NetworkService: Destroy NetworkContexts on NetworkService teardown. (patchset #3 id:40001 of https://codereview.chromium.org/2962693002/ ) Reason for revert: This conflicted with https://codereview.chromium.org/2951813002/, which landed at about the same time. Will fix and reland. Original issue's description: > NetworkService: Destroy NetworkContexts on NetworkService teardown. > > Also fix NetworkContexts potentially not being destroyed on connection > error / consumer teardown, due to calling str::move twice on the same > RequestPtr. > > BUG=736472 > > Review-Url: https://codereview.chromium.org/2962693002 > Cr-Commit-Position: refs/heads/master@{#482745} > Committed: https://chromium.googlesource.com/chromium/src/+/cfbf85b0c37adf3acccead282bf5c9b794ba4009 TBR=jam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=736472 Review-Url: https://codereview.chromium.org/2960843005 Cr-Commit-Position: refs/heads/master@{#482763} Committed: https://chromium.googlesource.com/chromium/src/+/1caf74b3fa2e801138207bae19471d408298268b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -169 lines) Patch
M content/network/network_context.h View 2 chunks +1 line, -12 lines 0 comments Download
M content/network/network_context.cc View 4 chunks +4 lines, -29 lines 0 comments Download
M content/network/network_service.h View 3 chunks +4 lines, -23 lines 0 comments Download
M content/network/network_service.cc View 2 chunks +11 lines, -36 lines 0 comments Download
D content/network/network_service_unittest.cc View 1 chunk +0 lines, -68 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
mmenke
Created Revert of NetworkService: Destroy NetworkContexts on NetworkService teardown.
3 years, 5 months ago (2017-06-27 22:18:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960843005/1
3 years, 5 months ago (2017-06-27 22:18:44 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 22:19:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1caf74b3fa2e801138207bae1947...

Powered by Google App Engine
This is Rietveld 408576698