Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2963763003: In QUIC, send data is copied to streams rather than frames. Protected by FLAGS_quic_reloadable_flag… (Closed)

Created:
3 years, 5 months ago by wangyix1
Modified:
3 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

In QUIC, send data is copied to streams rather than frames. Protected by FLAGS_quic_reloadable_flag_quic_stream_owns_data. This change is a preparation of copying data before data is consumed. Merge internal change: 159690069 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1025 lines, -82 lines) Patch
M net/BUILD.gn View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/core/frames/quic_stream_frame.h View 2 chunks +8 lines, -0 lines 0 comments Download
M net/quic/core/frames/quic_stream_frame.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.h View 3 chunks +29 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 8 chunks +17 lines, -14 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_framer.h View 3 chunks +5 lines, -2 lines 0 comments Download
M net/quic/core/quic_framer.cc View 5 chunks +19 lines, -3 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.h View 5 chunks +16 lines, -1 line 0 comments Download
M net/quic/core/quic_packet_creator.cc View 8 chunks +69 lines, -25 lines 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 7 chunks +39 lines, -27 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_packet_generator.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 4 chunks +20 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.h View 3 chunks +15 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.cc View 2 chunks +36 lines, -1 line 0 comments Download
M net/quic/core/quic_spdy_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/quic_stream.h View 3 chunks +16 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream.cc View 3 chunks +20 lines, -1 line 0 comments Download
A net/quic/core/quic_stream_frame_data_producer.h View 1 chunk +39 lines, -0 lines 0 comments Download
A net/quic/core/quic_stream_send_buffer.h View 1 chunk +73 lines, -0 lines 0 comments Download
A net/quic/core/quic_stream_send_buffer.cc View 1 chunk +94 lines, -0 lines 0 comments Download
A net/quic/core/quic_stream_send_buffer_test.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 5 chunks +89 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_stream_peer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_stream_peer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 5 chunks +57 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 5 chunks +64 lines, -1 line 0 comments Download
A net/quic/test_tools/simple_data_producer.h View 1 chunk +49 lines, -0 lines 0 comments Download
A net/quic/test_tools/simple_data_producer.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M net/quic/test_tools/simulator/quic_endpoint.h View 3 chunks +12 lines, -0 lines 0 comments Download
M net/quic/test_tools/simulator/quic_endpoint.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 3 chunks +23 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (8 generated)
wangyix1
3 years, 5 months ago (2017-06-28 19:24:00 UTC) #1
Ryan Hamilton
any idea why the two bots are red? looks like crashing tests.
3 years, 5 months ago (2017-06-29 02:55:22 UTC) #10
wangyix1
3 years, 5 months ago (2017-06-29 19:29:06 UTC) #11
On 2017/06/29 02:55:22, Ryan Hamilton wrote:
> any idea why the two bots are red? looks like crashing tests.

Asked fayang@, he says he doesn't know the cause. He'll merge this later and I
can skip for now.

Powered by Google App Engine
This is Rietveld 408576698