Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 2962773003: Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice. (Closed)

Created:
3 years, 5 months ago by wangyix1
Modified:
3 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add QUIC_PLOG to gfe/quic/platform and use it in TunDevice. Merge internal change: 159704484 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Changed PLOG(severity) to DVLOG(1) #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/quic/platform/api/quic_logging.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/platform/impl/quic_logging_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (16 generated)
wangyix1
3 years, 5 months ago (2017-06-28 19:44:23 UTC) #1
Ryan Hamilton
3 years, 5 months ago (2017-06-29 02:51:31 UTC) #10
https://codereview.chromium.org/2962773003/diff/20001/net/quic/platform/impl/...
File net/quic/platform/impl/quic_logging_impl.h (right):

https://codereview.chromium.org/2962773003/diff/20001/net/quic/platform/impl/...
net/quic/platform/impl/quic_logging_impl.h:60: #define QUIC_PLOG_IMPL(severity)
PLOG(severity)
I'm not sure if we have PLOG in chromium, so you can probably make this DVLOG(1)
or some such.

Powered by Google App Engine
This is Rietveld 408576698