Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: net/quic/core/frames/quic_stream_frame.h

Issue 2963763003: In QUIC, send data is copied to streams rather than frames. Protected by FLAGS_quic_reloadable_flag… (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/quic/core/frames/quic_stream_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/frames/quic_stream_frame.h
diff --git a/net/quic/core/frames/quic_stream_frame.h b/net/quic/core/frames/quic_stream_frame.h
index 138cc4831723880eec53b9f2a7fb4b05eb07d82a..90cfbfe8d2ce1f7e7308b0576c78ea1191f246fe 100644
--- a/net/quic/core/frames/quic_stream_frame.h
+++ b/net/quic/core/frames/quic_stream_frame.h
@@ -50,6 +50,10 @@ struct QUIC_EXPORT_PRIVATE QuicStreamFrame {
QuicStreamOffset offset,
QuicPacketLength data_length,
UniqueStreamBuffer buffer);
+ QuicStreamFrame(QuicStreamId stream_id,
+ bool fin,
+ QuicStreamOffset offset,
+ QuicPacketLength data_length);
~QuicStreamFrame();
friend QUIC_EXPORT_PRIVATE std::ostream& operator<<(std::ostream& os,
@@ -60,6 +64,10 @@ struct QUIC_EXPORT_PRIVATE QuicStreamFrame {
QuicPacketLength data_length;
const char* data_buffer;
QuicStreamOffset offset; // Location of this data in the stream.
+ // TODO(fayang): When deprecating
+ // FLAGS_quic_reloadable_flag_quic_stream_owns_data: (1) Remove buffer from
+ // QuicStreamFrame; (2) remove the constructor uses UniqueStreamBuffer and (3)
+ // Move definition of UniqueStreamBuffer to QuicStreamSendBuffer.
// nullptr when the QuicStreamFrame is received, and non-null when sent.
UniqueStreamBuffer buffer;
« no previous file with comments | « net/BUILD.gn ('k') | net/quic/core/frames/quic_stream_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698