Clarify SQlite threadsafety compile flags.

Clarify SQlite threadsafety compile flags.

The Chrome build was setting THREADSAFE=1 on sqlite. But sqlite does not use
this flag (at least any more).

The flag sqlite expects is SQLITE_THREADSAFE. The default is the most
threadsafety which is then what we were getting. This patch makes that choice
explicit. There should be no change in behavior since 1 is the default. The
return value from sqlite3_threadsafe was verified to be the same (=1) both with
and without this patch.

Review-Url: https://codereview.chromium.org/2963633002
Cr-Commit-Position: refs/heads/master@{#482837}
Committed: https://chromium.googlesource.com/chromium/src/+/1be4c8f7053d29f3dbc0f7d21d341c04d9e63acc

[brettw, 2017-06-27 21:57:27]

brettw@chromium.org changed reviewers:
+ sky@chromium.org

[brettw, 2017-06-27 21:57:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-27 21:58:10]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-06-27 22:10:26]

LGTM

[brettw, 2017-06-27 22:19:42]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2017-06-27 22:19:45]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2017-06-27 22:20:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 01:11:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498601985245600, "parent_rev":
"1002aba016a21c72ad9aa8d0394f5af17113cc61", "commit_rev":
"1be4c8f7053d29f3dbc0f7d21d341c04d9e63acc"}

[commit-bot: I haz the power, 2017-06-28 01:12:02]

Description was changed from

==========
Clarify SQlite threadsafety compile flags.

The Chrome build was setting THREADSAFE=1 on sqlite. But sqlite does not use
this flag (at least any more).

The flag sqlite expects is SQLITE_THREADSAFE. The default is the most
threadsafety which is then what we were getting. This patch makes that choice
explicit. There should be no change in behavior since 1 is the default. The
return value from sqlite3_threadsafe was verified to be the same (=1) both with
and without this patch.
==========

to

==========
Clarify SQlite threadsafety compile flags.

The Chrome build was setting THREADSAFE=1 on sqlite. But sqlite does not use
this flag (at least any more).

The flag sqlite expects is SQLITE_THREADSAFE. The default is the most
threadsafety which is then what we were getting. This patch makes that choice
explicit. There should be no change in behavior since 1 is the default. The
return value from sqlite3_threadsafe was verified to be the same (=1) both with
and without this patch.

Review-Url: https://codereview.chromium.org/2963633002
Cr-Commit-Position: refs/heads/master@{#482837}
Committed:
https://chromium.googlesource.com/chromium/src/+/1be4c8f7053d29f3dbc0f7d21d34...
==========

[commit-bot: I haz the power, 2017-06-28 01:12:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1be4c8f7053d29f3dbc0f7d21d34...