Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/sqlite/BUILD.gn

Issue 2963633002: Clarify SQlite threadsafety compile flags. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/BUILD.gn
diff --git a/third_party/sqlite/BUILD.gn b/third_party/sqlite/BUILD.gn
index a5e030f11d1b3daba1d41fceb70b75573e385f3c..a518797c5936aa857b2347fa883151e543192ec3 100644
--- a/third_party/sqlite/BUILD.gn
+++ b/third_party/sqlite/BUILD.gn
@@ -63,9 +63,10 @@ if (!use_system_sqlite) {
"SQLITE_SEPARATE_CACHE_POOLS",
# TODO(shess): SQLite adds mutexes to protect structures which cross
- # threads. In theory Chromium should be able to turn this off for a
- # slight speed boost.
- "THREADSAFE",
+ # threads. In theory Chromium should be able to turn this to "2" which
+ # should give a slight speed boost. "2" is safe as long as a single
+ # connection is not used by more than one thread at a time.
+ "SQLITE_THREADSAFE=1",
# SQLite can spawn threads to sort in parallel if configured
# appropriately. Chromium doesn't configure SQLite for that, and would
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698