[wasm] Remove some small TODOs and small fixes.

[wasm] Remove some small TODOs and small fixes.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2963603003
Cr-Commit-Position: refs/heads/master@{#46283}
Committed: https://chromium.googlesource.com/v8/v8/+/94bac158a29e433676dc23ccf6e8dd697c0c3496

[titzer, 2017-06-28 11:24:25]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 11:24:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 11:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 11:55:22]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2017-06-28 11:55:37]

lgtm

https://codereview.chromium.org/2963603003/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (left):

https://codereview.chromium.org/2963603003/diff/1/src/wasm/wasm-module.h#oldc...
src/wasm/wasm-module.h:192: // switch to libc-2.21 or higher.
I assume you checked that all bots use libc >= 2.21.

[ahaas, 2017-06-28 11:57:09]

lgtm

[Clemens Hammacher, 2017-06-28 11:57:45]

https://codereview.chromium.org/2963603003/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (left):

https://codereview.chromium.org/2963603003/diff/1/src/wasm/wasm-module.h#oldc...
src/wasm/wasm-module.h:192: // switch to libc-2.21 or higher.
On 2017/06/28 at 11:55:37, Clemens Hammacher wrote:
> I assume you checked that all bots use libc >= 2.21.

Oh, IC, this field is completely dead now :)

[ahaas, 2017-06-28 11:58:28]

https://codereview.chromium.org/2963603003/diff/1/src/wasm/wasm-module.h
File src/wasm/wasm-module.h (left):

https://codereview.chromium.org/2963603003/diff/1/src/wasm/wasm-module.h#oldc...
src/wasm/wasm-module.h:192: // switch to libc-2.21 or higher.
On 2017/06/28 at 11:55:37, Clemens Hammacher wrote:
> I assume you checked that all bots use libc >= 2.21.

it's more that the semaphore is not used anymore.

[titzer, 2017-06-28 12:04:58]

The CQ bit was checked by titzer@chromium.org

[commit-bot: I haz the power, 2017-06-28 12:05:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 12:09:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498651498941890, "parent_rev":
"7d232d7d6a56da74615a41573087eee8239a9703", "commit_rev":
"94bac158a29e433676dc23ccf6e8dd697c0c3496"}

[commit-bot: I haz the power, 2017-06-28 12:09:14]

Description was changed from

==========
[wasm] Remove some small TODOs and small fixes.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=
==========

to

==========
[wasm] Remove some small TODOs and small fixes.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2963603003
Cr-Commit-Position: refs/heads/master@{#46283}
Committed:
https://chromium.googlesource.com/v8/v8/+/94bac158a29e433676dc23ccf6e8dd697c0...
==========

[commit-bot: I haz the power, 2017-06-28 12:09:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/94bac158a29e433676dc23ccf6e8dd697c0...