Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1590)

Unified Diff: src/wasm/wasm-module.h

Issue 2963603003: [wasm] Remove some small TODOs and small fixes. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/wasm/wasm-js.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.h
diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h
index 9fbeb2d7c90e73abaab38839a45a8852cc0cc2dc..bc67d66436f4fb81bb05a67bbc38a355d311943e 100644
--- a/src/wasm/wasm-module.h
+++ b/src/wasm/wasm-module.h
@@ -183,14 +183,6 @@ struct V8_EXPORT_PRIVATE WasmModule {
std::vector<WasmImport> import_table; // import table.
std::vector<WasmExport> export_table; // export table.
std::vector<WasmTableInit> table_inits; // initializations of tables
- // We store the semaphore here to extend its lifetime. In <libc-2.21, which we
- // use on the try bots, semaphore::Wait() can return while some compilation
- // tasks are still executing semaphore::Signal(). If the semaphore is cleaned
- // up right after semaphore::Wait() returns, then this can cause an
- // invalid-semaphore error in the compilation tasks.
- // TODO(wasm): Move this semaphore back to CompileInParallel when the try bots
- // switch to libc-2.21 or higher.
Clemens Hammacher 2017/06/28 11:55:37 I assume you checked that all bots use libc >= 2.2
Clemens Hammacher 2017/06/28 11:57:45 Oh, IC, this field is completely dead now :)
ahaas 2017/06/28 11:58:28 it's more that the semaphore is not used anymore.
- std::unique_ptr<base::Semaphore> pending_tasks;
WasmModule() : WasmModule(nullptr) {}
WasmModule(std::unique_ptr<Zone> owned);
« no previous file with comments | « src/wasm/wasm-js.cc ('k') | src/wasm/wasm-module.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698