Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2963453002: Settings: Network: Fix logic building VPN list from Tether merge. (Closed)

Created:
3 years, 5 months ago by stevenjb
Modified:
3 years, 5 months ago
Reviewers:
Kyle Horimoto
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Network: Fix logic building VPN list from Tether merge. Incorrect nesting introduced a bug in this CL: https://codereview.chromium.org/2913323003 This fixes that bug. BUG=733376 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2963453002 Cr-Commit-Position: refs/heads/master@{#482454} Committed: https://chromium.googlesource.com/chromium/src/+/c3ffa5f9c0f6c2cb7405fdfb09d3b59801caf250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/settings/internet_page/internet_subpage.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
Oops, this was my bad.
3 years, 5 months ago (2017-06-26 21:24:18 UTC) #3
Kyle Horimoto
lgtm
3 years, 5 months ago (2017-06-26 21:35:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963453002/1
3 years, 5 months ago (2017-06-26 21:51:59 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 23:23:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3ffa5f9c0f6c2cb7405fdfb09d3...

Powered by Google App Engine
This is Rietveld 408576698