Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 2963103002: Always treat TokenError as fatal error. (Closed)

Created:
3 years, 5 months ago by Vadim Sh.
Modified:
3 years, 5 months ago
Reviewers:
dnj, smut
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Always treat TokenError as fatal error. There is RPCError(500, ...) exception to indicate transient errors. It makes more sense on protocol level (HTTP 500 status code). R=smut@google.com, dnj@chromium.org BUG=730878 Review-Url: https://codereview.chromium.org/2963103002 Committed: https://github.com/luci/luci-py/commit/f181ec078bfbd4144696473fc279a3abcfaa5147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -31 lines) Patch
M appengine/swarming/swarming_bot/bot_code/bot_auth.py View 1 chunk +1 line, -1 line 0 comments Download
M client/tests/auth_server_test.py View 1 chunk +7 lines, -19 lines 0 comments Download
M client/utils/auth_server.py View 3 chunks +9 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Vadim Sh.
Tiny CL. Will simplify following code a little bit.
3 years, 5 months ago (2017-06-29 04:04:06 UTC) #1
dnj
lgtm
3 years, 5 months ago (2017-06-29 16:26:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2963103002/1
3 years, 5 months ago (2017-06-29 16:41:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-py/commit/f181ec078bfbd4144696473fc279a3abcfaa5147
3 years, 5 months ago (2017-06-29 17:16:23 UTC) #7
smut
3 years, 5 months ago (2017-06-29 22:27:54 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698