Add 'mint_oauth_token' method to RPC client.

Add 'mint_oauth_token' method to RPC client.

R=smut@google.com, dnj@chromium.org
BUG=730878
Review-Url: https://codereview.chromium.org/2958413002
Committed: https://github.com/luci/luci-py/commit/16835e957e45c020a4d6518dca7f1d0d749eb1b2

[Vadim Sh., 2017-06-29 04:58:44]

PTAL

It's just a stupid wrapper around HTTP call.

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/remote_client.py (right):

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client.py:312: resp =
self._url_read_json('/swarming/api/v1/bot/oauth_token', data={
this method is a turd

it doesn't communicate back HTTP status code, and getting it requires
non-trivial refactoring that touches a lot of bot and client code :(

So 'mint_oauth_token' currently provides okaish API, but the implementation is
sloppy.

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/remote_client_errors.py (right):

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client_errors.py:29: class
MintOAuthTokenError(Exception):
I'm just following established pattern in the code... New method, new
exception...

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/remote_client_test.py (right):

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client_test.py:80: def
test_mint_oauth_token_ok(self):
typo catching tests

RemoteClient seems to be not covered by tests at all...

[Vadim Sh., 2017-06-29 04:58:49]

The CQ bit was checked by vadimsh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 04:58:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dnj, 2017-06-29 16:29:27]

lgtm

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/remote_client.py (right):

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client.py:312: resp =
self._url_read_json('/swarming/api/v1/bot/oauth_token', data={
On 2017/06/29 04:58:44, Vadim Sh. wrote:
> this method is a turd
> 
> it doesn't communicate back HTTP status code, and getting it requires
> non-trivial refactoring that touches a lot of bot and client code :(
> 
> So 'mint_oauth_token' currently provides okaish API, but the implementation is
> sloppy.

Acknowledged.

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/remote_client_errors.py (right):

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client_errors.py:29: class
MintOAuthTokenError(Exception):
On 2017/06/29 04:58:44, Vadim Sh. wrote:
> I'm just following established pattern in the code... New method, new
> exception...

Acknowledged.

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/remote_client_test.py (right):

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client_test.py:80: def
test_mint_oauth_token_ok(self):
On 2017/06/29 04:58:44, Vadim Sh. wrote:
> typo catching tests
> 
> RemoteClient seems to be not covered by tests at all...

Acknowledged.

https://codereview.chromium.org/2958413002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/remote_client_test.py:105: return None 
# that's how net.url_read_json indicates HTTP 500 :-/
Lovely :x

https://codereview.chromium.org/2958413002/diff/20001/appengine/swarming/swar...
File appengine/swarming/swarming_bot/bot_code/remote_client.py (right):

https://codereview.chromium.org/2958413002/diff/20001/appengine/swarming/swar...
appengine/swarming/swarming_bot/bot_code/remote_client.py:287: """Asks the
server to generate an access token for a service accounts.
nit: s/accounts/account/

[Vadim Sh., 2017-06-29 18:20:43]

https://codereview.chromium.org/2958413002/diff/20001/appengine/swarming/swar...
File appengine/swarming/swarming_bot/bot_code/remote_client.py (right):

https://codereview.chromium.org/2958413002/diff/20001/appengine/swarming/swar...
appengine/swarming/swarming_bot/bot_code/remote_client.py:287: """Asks the
server to generate an access token for a service accounts.
On 2017/06/29 16:29:27, dnj wrote:
> nit: s/accounts/account/

Done.

[Vadim Sh., 2017-06-29 18:20:49]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2017-06-29 18:20:50]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/2958413002/#ps40001
(title: "Add 'mint_oauth_token' method to RPC client.")

[commit-bot: I haz the power, 2017-06-29 18:20:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 18:24:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498760449795300,
"parent_rev": "71c3c10aecb784a070f19d47eabb4ccfebc6c6c2", "commit_rev":
"16835e957e45c020a4d6518dca7f1d0d749eb1b2"}

[commit-bot: I haz the power, 2017-06-29 18:24:47]

Description was changed from

==========
Add 'mint_oauth_token' method to RPC client.

R=smut@google.com, dnj@chromium.org
BUG=730878
==========

to

==========
Add 'mint_oauth_token' method to RPC client.

R=smut@google.com, dnj@chromium.org
BUG=730878

Review-Url: https://codereview.chromium.org/2958413002
Committed:
https://github.com/luci/luci-py/commit/16835e957e45c020a4d6518dca7f1d0d749eb1b2
==========

[commit-bot: I haz the power, 2017-06-29 18:24:48]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-py/commit/16835e957e45c020a4d6518dca7f1d0d749eb1b2

[smut, 2017-06-29 22:29:40]

lgtm