Use kColorId_LabelEnabledColor in Checkbox, not kColorId_ButtonEnabledColor

Use kColorId_LabelEnabledColor in Checkbox, not kColorId_ButtonEnabledColor

Checkbox uses views::Button::STYLE_TEXTBUTTON, but only STYLE_BUTTON
uses kColorId_ButtonEnabledColor in views::LabelButton (which
views::Checkbox inherits from). Fix it.

Also use the CreateDefaultInkDropRipple helper in
Checkbox::CreateInkDropRipple()

Ripples under harmony aren't derived from text colors, so we want to
consolidate calls to the SquareInkDropRipple constructor. This special
case isn't actually special.

BUG=691891
Review-Url: https://codereview.chromium.org/2963083003
Cr-Commit-Position: refs/heads/master@{#483650}
Committed: https://chromium.googlesource.com/chromium/src/+/2d322753596b18ed0d10242424edcefe4da835f2

[tapted, 2017-06-29 04:43:57]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 04:44:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-29 05:15:51]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 05:15:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-29 06:31:26]

Description was changed from

==========
Use the CreateDefaultInkDropRipple helper in Checkbox::CreateInkDropRipple()

Ripples under harmony aren't derived from font colors, so we want to
consolidate calls to the SquareInkDropRipple constructor. This special
case isn't actually special.

BUG=691891
==========

to

==========
Use kColorId_LabelEnabledColor in Checkbox, not kColorId_ButtonEnabledColor

Checkbox uses views::Button::STYLE_TEXTBUTTON, but only STYLE_BUTTON
uses kColorId_ButtonEnabledColor in views::LabelButton (which
views::Checkbox inherits from). Fix it.

Also use the CreateDefaultInkDropRipple helper in
Checkbox::CreateInkDropRipple()

Ripples under harmony aren't derived from text colors, so we want to
consolidate calls to the SquareInkDropRipple constructor. This special
case isn't actually special.

BUG=691891
==========

[tapted, 2017-06-29 06:31:26]

tapted@chromium.org changed reviewers:
+ pkasting@chromium.org

[commit-bot: I haz the power, 2017-06-29 06:41:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 06:41:16]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tapted, 2017-06-29 10:20:05]

[1/4] PTAL

https://codereview.chromium.org/2963083003/diff/20001/ui/views/controls/butto...
File ui/views/controls/button/checkbox.cc (right):

https://codereview.chromium.org/2963083003/diff/20001/ui/views/controls/butto...
ui/views/controls/button/checkbox.cc:154: return
CreateDefaultInkDropRipple(image()->GetMirroredBounds().CenterPoint(),
This is
https://cs.chromium.org/chromium/src/ui/views/animation/ink_drop_host_view.cc...

std::unique_ptr<InkDropRipple> InkDropHostView::CreateDefaultInkDropRipple(
    const gfx::Point& center_point,
    const gfx::Size& size) const {
  std::unique_ptr<InkDropRipple> ripple(new SquareInkDropRipple(
      CalculateLargeInkDropSize(size), kInkDropLargeCornerRadius, size,
      kInkDropSmallCornerRadius, center_point, GetInkDropBaseColor(),
      ink_drop_visible_opacity()));
  return ripple;
}

[Peter Kasting, 2017-06-29 19:49:06]

LGTM

[tapted, 2017-06-30 06:08:18]

(sending this one to CQ - it's isolated from everything else. There are some
windows bots that need to re-run to give time for objections ;)

[tapted, 2017-06-30 06:08:29]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-06-30 06:08:36]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 07:18:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498802909823660,
"parent_rev": "0742bd89cb1e343d97c1dc7b2376fa79e8b3d39c", "commit_rev":
"2d322753596b18ed0d10242424edcefe4da835f2"}

[commit-bot: I haz the power, 2017-06-30 07:18:13]

Description was changed from

==========
Use kColorId_LabelEnabledColor in Checkbox, not kColorId_ButtonEnabledColor

Checkbox uses views::Button::STYLE_TEXTBUTTON, but only STYLE_BUTTON
uses kColorId_ButtonEnabledColor in views::LabelButton (which
views::Checkbox inherits from). Fix it.

Also use the CreateDefaultInkDropRipple helper in
Checkbox::CreateInkDropRipple()

Ripples under harmony aren't derived from text colors, so we want to
consolidate calls to the SquareInkDropRipple constructor. This special
case isn't actually special.

BUG=691891
==========

to

==========
Use kColorId_LabelEnabledColor in Checkbox, not kColorId_ButtonEnabledColor

Checkbox uses views::Button::STYLE_TEXTBUTTON, but only STYLE_BUTTON
uses kColorId_ButtonEnabledColor in views::LabelButton (which
views::Checkbox inherits from). Fix it.

Also use the CreateDefaultInkDropRipple helper in
Checkbox::CreateInkDropRipple()

Ripples under harmony aren't derived from text colors, so we want to
consolidate calls to the SquareInkDropRipple constructor. This special
case isn't actually special.

BUG=691891

Review-Url: https://codereview.chromium.org/2963083003
Cr-Commit-Position: refs/heads/master@{#483650}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d322753596b18ed0d10242424ed...
==========

[commit-bot: I haz the power, 2017-06-30 07:18:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2d322753596b18ed0d10242424ed...