Hardcode ripple color/opacity for Harmony.

Hardcode ripple color/opacity for Harmony.

Text colors are changing under harmony. Ripple colors are not.

Currently the ripple color comes from GetInkDropBaseColor() which tends
to be derived from text color or something derived, again, from that
e.g. via color_utils::DeriveDefaultIconColor().

Specs just say ripples should be black, with 0.05 opacity. Do that for
LabelButton, MdTextButton, and Combobox when --secondary-ui-md is set.
Aim to reduce the reliance on GetInkDropBaseColor() under Harmony, since
it should be constant.

BUG=691891

[tapted, 2017-06-29 05:10:15]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 05:10:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 05:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 05:30:50]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tapted, 2017-06-29 05:55:12]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 05:55:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-06-29 06:37:06]

Description was changed from

==========
Hardcode ripples for Harmony.

Specs just say they should be black, with 0.05 opacity.

BUG=691891
==========

to

==========
Hardcode ripple color/opacity for Harmony.

Text colors are changing under harmony. Ripple colors are not.

Currently the ripple color comes from GetInkDropBaseColor() which tends
to be derived from text color or something derived, again, from that
e.g. via color_utils::DeriveDefaultIconColor().

Specs just say ripples should be black, with 0.05 opacity. Do that for
LabelButton, MdTextButton, and Combobox when --secondary-ui-md is set.
Aim to reduce the reliance on GetInkDropBaseColor() under Harmony, since
it should be constant.

BUG=691891
==========

[tapted, 2017-06-29 06:37:06]

tapted@chromium.org changed reviewers:
+ pkasting@chromium.org

[commit-bot: I haz the power, 2017-06-29 07:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 07:37:41]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Peter Kasting, 2017-08-29 04:02:59]

Hey, I seem to have totally missed this.  Is it still valuable?  If so I'm happy
to review.  Sorry!

[tapted, 2017-08-31 00:35:36]

On 2017/08/29 04:02:59, Peter Kasting wrote:
> Hey, I seem to have totally missed this.  Is it still valuable?  If so I'm
happy
> to review.  Sorry!

Huh. I'd forgotten about this. I don't think I ever published it, but there's
probably something in it. And certainly if the CL description is correct, and
the spec really does, always, want the same ripple color this will lead to some
simplifications (and likely fix small errors in what's done currently).

Although when I was exploring this, I think I encountered a couple of awkward
use-cases where it was possible for text color to be wildly different from
black. Like, inverted color schemes, where the approach in this CL might mess
things up pretty bad. So it got put on the backburner.

Anyway, I'll upload a new CL in gerrit if I pick this up again.

[tapted, 2017-08-31 00:35:50]

tapted@chromium.org changed reviewers:
- pkasting@chromium.org

[Peter Kasting, 2017-08-31 01:07:39]

On 2017/08/31 00:35:36, tapted wrote:
> Anyway, I'll upload a new CL in gerrit if I pick this up again.

OK, closing.