Reland of Change ScopedFeatureList to overrides FeatureList not reset

Reland of Change ScopedFeatureList to overrides FeatureList not reset (patchset #1 id:1 of https://codereview.chromium.org/2850073002/ )

Reason for revert:
The ASAN failure is fixed at https://codereview.chromium.org/2874693002/. 

This patch is ready for reland.

Original issue's description:
> Revert of Change ScopedFeatureList to overrides FeatureList not reset (patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )
> 
> Reason for revert:
> Mac ASAN bots reporting use-after-free errors.
> 
> Original issue's description:
> > Change ScopedFeatureList to overrides FeatureList not reset
> > 
> > The current situation is that using ScopedFeatureList resets to an
> > empty feature list and then enables/disables an explicit list of
> > features.
> > 
> > That's never what you want for browser tests (or other higher-level
> > tests) since it effectively overrides higher-level test configurations
> > (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> > specifically test a feature).
> > 
> > In this patch:
> > 
> > 1. Keep SFL::Init, SFL::InitWithFeatureList,
> >    SFL::InitFromCommandLine reset to empty list but add warning to
> >    remind developer should use them with care.
> > 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
> >    SFL::InitWithFeatures to not reset but override current FeatureList
> >    with given enables/disables.
> > 
> > We also add unit tests for ScopedFeatureList.
> > 
> > BUG=713390
> > 
> > Review-Url: https://codereview.chromium.org/2834583002
> > Cr-Commit-Position: refs/heads/master@{#468210}
> > Committed: https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e8981e6738881a9
> 
> TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng@chromium.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=713390
> 
> Review-Url: https://codereview.chromium.org/2850073002
> Cr-Commit-Position: refs/heads/master@{#468263}
> Committed: https://chromium.googlesource.com/chromium/src/+/6c14f269fb196627c72a810205488d694b63a7d5

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,thestig@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390
Review-Url: https://codereview.chromium.org/2962963002
Cr-Commit-Position: refs/heads/master@{#483631}
Committed: https://chromium.googlesource.com/chromium/src/+/04afdfd65fe04ef71fa9918d8fea0f2bc6356836

[chaopeng, 2017-06-28 19:22:18]

The CQ bit was checked by chaopeng@chromium.org

[chaopeng, 2017-06-28 19:22:18]

Created Reland of Change ScopedFeatureList to overrides FeatureList not reset

[commit-bot: I haz the power, 2017-06-28 19:22:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 19:22:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 19:22:44]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[chaopeng, 2017-06-28 19:27:48]

The ASAN failure is fixed at https://codereview.chromium.org/2874693002/. 

Want to reland this CL.
PTAL. Thank you.

[chaopeng, 2017-06-28 19:28:16]

Description was changed from

==========
Reland of Change ScopedFeatureList to overrides FeatureList not reset (patchset
#1 id:1 of https://codereview.chromium.org/2850073002/ )

Reason for revert:
Ready for reland.

Original issue's description:
> Revert of Change ScopedFeatureList to overrides FeatureList not reset
(patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )
> 
> Reason for revert:
> Mac ASAN bots reporting use-after-free errors.
> 
> Original issue's description:
> > Change ScopedFeatureList to overrides FeatureList not reset
> > 
> > The current situation is that using ScopedFeatureList resets to an
> > empty feature list and then enables/disables an explicit list of
> > features.
> > 
> > That's never what you want for browser tests (or other higher-level
> > tests) since it effectively overrides higher-level test configurations
> > (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> > specifically test a feature).
> > 
> > In this patch:
> > 
> > 1. Keep SFL::Init, SFL::InitWithFeatureList,
> >    SFL::InitFromCommandLine reset to empty list but add warning to
> >    remind developer should use them with care.
> > 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
> >    SFL::InitWithFeatures to not reset but override current FeatureList
> >    with given enables/disables.
> > 
> > We also add unit tests for ScopedFeatureList.
> > 
> > BUG=713390
> > 
> > Review-Url: https://codereview.chromium.org/2834583002
> > Cr-Commit-Position: refs/heads/master@{#468210}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e89...
> 
>
TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=713390
> 
> Review-Url: https://codereview.chromium.org/2850073002
> Cr-Commit-Position: refs/heads/master@{#468263}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6c14f269fb196627c72a81020548...

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,thestig@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390
==========

to

==========
Reland of Change ScopedFeatureList to overrides FeatureList not reset (patchset
#1 id:1 of https://codereview.chromium.org/2850073002/ )

Reason for revert:
The ASAN failure is fixed at https://codereview.chromium.org/2874693002/. 

This patch is ready for reland.

Original issue's description:
> Revert of Change ScopedFeatureList to overrides FeatureList not reset
(patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )
> 
> Reason for revert:
> Mac ASAN bots reporting use-after-free errors.
> 
> Original issue's description:
> > Change ScopedFeatureList to overrides FeatureList not reset
> > 
> > The current situation is that using ScopedFeatureList resets to an
> > empty feature list and then enables/disables an explicit list of
> > features.
> > 
> > That's never what you want for browser tests (or other higher-level
> > tests) since it effectively overrides higher-level test configurations
> > (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> > specifically test a feature).
> > 
> > In this patch:
> > 
> > 1. Keep SFL::Init, SFL::InitWithFeatureList,
> >    SFL::InitFromCommandLine reset to empty list but add warning to
> >    remind developer should use them with care.
> > 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
> >    SFL::InitWithFeatures to not reset but override current FeatureList
> >    with given enables/disables.
> > 
> > We also add unit tests for ScopedFeatureList.
> > 
> > BUG=713390
> > 
> > Review-Url: https://codereview.chromium.org/2834583002
> > Cr-Commit-Position: refs/heads/master@{#468210}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e89...
> 
>
TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=713390
> 
> Review-Url: https://codereview.chromium.org/2850073002
> Cr-Commit-Position: refs/heads/master@{#468263}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6c14f269fb196627c72a81020548...

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,thestig@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390
==========

[Ilya Sherman, 2017-06-28 19:42:09]

lgtm

[chaopeng, 2017-06-28 21:03:49]

The CQ bit was checked by chaopeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 21:04:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-28 22:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 22:27:39]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2017-06-30 03:39:15]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2017-06-30 03:39:16]

lgtm

[commit-bot: I haz the power, 2017-06-30 03:39:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 04:47:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498793955834320, "parent_rev":
"47c2896ff9bad0082bf8abddd0e55bfdd843a959", "commit_rev":
"04afdfd65fe04ef71fa9918d8fea0f2bc6356836"}

[commit-bot: I haz the power, 2017-06-30 04:47:38]

Description was changed from

==========
Reland of Change ScopedFeatureList to overrides FeatureList not reset (patchset
#1 id:1 of https://codereview.chromium.org/2850073002/ )

Reason for revert:
The ASAN failure is fixed at https://codereview.chromium.org/2874693002/. 

This patch is ready for reland.

Original issue's description:
> Revert of Change ScopedFeatureList to overrides FeatureList not reset
(patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )
> 
> Reason for revert:
> Mac ASAN bots reporting use-after-free errors.
> 
> Original issue's description:
> > Change ScopedFeatureList to overrides FeatureList not reset
> > 
> > The current situation is that using ScopedFeatureList resets to an
> > empty feature list and then enables/disables an explicit list of
> > features.
> > 
> > That's never what you want for browser tests (or other higher-level
> > tests) since it effectively overrides higher-level test configurations
> > (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> > specifically test a feature).
> > 
> > In this patch:
> > 
> > 1. Keep SFL::Init, SFL::InitWithFeatureList,
> >    SFL::InitFromCommandLine reset to empty list but add warning to
> >    remind developer should use them with care.
> > 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
> >    SFL::InitWithFeatures to not reset but override current FeatureList
> >    with given enables/disables.
> > 
> > We also add unit tests for ScopedFeatureList.
> > 
> > BUG=713390
> > 
> > Review-Url: https://codereview.chromium.org/2834583002
> > Cr-Commit-Position: refs/heads/master@{#468210}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e89...
> 
>
TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=713390
> 
> Review-Url: https://codereview.chromium.org/2850073002
> Cr-Commit-Position: refs/heads/master@{#468263}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6c14f269fb196627c72a81020548...

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,thestig@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390
==========

to

==========
Reland of Change ScopedFeatureList to overrides FeatureList not reset (patchset
#1 id:1 of https://codereview.chromium.org/2850073002/ )

Reason for revert:
The ASAN failure is fixed at https://codereview.chromium.org/2874693002/. 

This patch is ready for reland.

Original issue's description:
> Revert of Change ScopedFeatureList to overrides FeatureList not reset
(patchset #6 id:140001 of https://codereview.chromium.org/2834583002/ )
> 
> Reason for revert:
> Mac ASAN bots reporting use-after-free errors.
> 
> Original issue's description:
> > Change ScopedFeatureList to overrides FeatureList not reset
> > 
> > The current situation is that using ScopedFeatureList resets to an
> > empty feature list and then enables/disables an explicit list of
> > features.
> > 
> > That's never what you want for browser tests (or other higher-level
> > tests) since it effectively overrides higher-level test configurations
> > (e.g. those in fieldtrial_testing_config.json, or a bot set up to
> > specifically test a feature).
> > 
> > In this patch:
> > 
> > 1. Keep SFL::Init, SFL::InitWithFeatureList,
> >    SFL::InitFromCommandLine reset to empty list but add warning to
> >    remind developer should use them with care.
> > 2. Change SFL::InitAndEnableFeature, SFL::InitAndDisableFeature and
> >    SFL::InitWithFeatures to not reset but override current FeatureList
> >    with given enables/disables.
> > 
> > We also add unit tests for ScopedFeatureList.
> > 
> > BUG=713390
> > 
> > Review-Url: https://codereview.chromium.org/2834583002
> > Cr-Commit-Position: refs/heads/master@{#468210}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/9c04ed553bd7abe820a6a93c5e89...
> 
>
TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,chaopeng...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=713390
> 
> Review-Url: https://codereview.chromium.org/2850073002
> Cr-Commit-Position: refs/heads/master@{#468263}
> Committed:
https://chromium.googlesource.com/chromium/src/+/6c14f269fb196627c72a81020548...

TBR=isherman@chromium.org,asvitkine@chromium.org,thakis@chromium.org,thestig@...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713390

Review-Url: https://codereview.chromium.org/2962963002
Cr-Commit-Position: refs/heads/master@{#483631}
Committed:
https://chromium.googlesource.com/chromium/src/+/04afdfd65fe04ef71fa9918d8fea...
==========

[commit-bot: I haz the power, 2017-06-30 04:47:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/04afdfd65fe04ef71fa9918d8fea...

[Timothy Loh, 2017-06-30 06:02:16]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2964623002/ by timloh@chromium.org.

The reason for reverting is: Causing Mac bots to OOM on AppShimInteractiveTest
tests

https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_....

[findit-for-me, 2017-07-01 14:58:35]

Findit (https://goo.gl/kROfz5) identified this CL at revision 483631 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...