Fix SetUp of HostedAppTest and AppShimMenuControllerBrowserTest

Fix SetUp of HostedAppTest and AppShimMenuControllerBrowserTest

We got a ASAN issue when we land crrev.com/2834583002. The ASAN issue shows
ScopedFeatureList::* calls happend after Shutdown/Test finish. In the stack
trace we also know, the test is run in InProcessBrowserTest::SetUp so all the
SetUp stuff should happen before SuperClass::SetUp.

In this patch, we only fix SetUp of HostedAppTest and
AppShimMenuControllerBrowserTest.

BUG=713390
Review-Url: https://codereview.chromium.org/2874693002
Cr-Commit-Position: refs/heads/master@{#470685}
Committed: https://chromium.googlesource.com/chromium/src/+/648090c24cfe95b072fe2099ffd4af9bd04aa724

[chaopeng, 2017-05-10 02:45:38]

chaopeng@chromium.org changed reviewers:
+ asvitkine@chromium.org, finnur@chromium.org

[chaopeng, 2017-05-10 02:45:38]

asvitkine@chromium.org, finnur@chromium.org: PTAL, Thank you.

[Finnur, 2017-05-10 10:49:26]

LGTM

[Alexei Svitkine (slow), 2017-05-10 14:46:08]

lgtm

[chaopeng, 2017-05-10 19:10:49]

The CQ bit was checked by chaopeng@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:12:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 20:27:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494443449667280, "parent_rev":
"fccaadd4b0451db39c4ae3b61fa1b6bc24afdc2b", "commit_rev":
"648090c24cfe95b072fe2099ffd4af9bd04aa724"}

[commit-bot: I haz the power, 2017-05-10 20:27:20]

Description was changed from

==========
Fix SetUp of HostedAppTest and AppShimMenuControllerBrowserTest

We got a ASAN issue when we land crrev.com/2834583002. The ASAN issue shows
ScopedFeatureList::* calls happend after Shutdown/Test finish. In the stack
trace we also know, the test is run in InProcessBrowserTest::SetUp so all the
SetUp stuff should happen before SuperClass::SetUp.

In this patch, we only fix SetUp of HostedAppTest and
AppShimMenuControllerBrowserTest.

BUG=713390
==========

to

==========
Fix SetUp of HostedAppTest and AppShimMenuControllerBrowserTest

We got a ASAN issue when we land crrev.com/2834583002. The ASAN issue shows
ScopedFeatureList::* calls happend after Shutdown/Test finish. In the stack
trace we also know, the test is run in InProcessBrowserTest::SetUp so all the
SetUp stuff should happen before SuperClass::SetUp.

In this patch, we only fix SetUp of HostedAppTest and
AppShimMenuControllerBrowserTest.

BUG=713390

Review-Url: https://codereview.chromium.org/2874693002
Cr-Commit-Position: refs/heads/master@{#470685}
Committed:
https://chromium.googlesource.com/chromium/src/+/648090c24cfe95b072fe2099ffd4...
==========

[commit-bot: I haz the power, 2017-05-10 20:27:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/648090c24cfe95b072fe2099ffd4...