Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2962603002: MD Settings: fix help/ redirection to only happen on chrome://help (Closed)

Created:
3 years, 5 months ago by Dan Beam
Modified:
3 years, 5 months ago
Reviewers:
tommycli, mmenke
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix help/ redirection to only happen on chrome://help R=tommycli@chromium.org BUG=735149 Review-Url: https://codereview.chromium.org/2949053004 Cr-Commit-Position: refs/heads/master@{#481981} (cherry picked from commit 25472e0c801c621e7bd907bbbc57b317efa56fa0) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2962603002 Cr-Commit-Position: refs/branch-heads/3112@{#470} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ae7d311954c7b6b2ea918f381b02e970359e6d6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Dan Beam
3 years, 5 months ago (2017-06-26 22:45:51 UTC) #2
mmenke
LGTM
3 years, 5 months ago (2017-06-26 22:45:57 UTC) #3
tommycli
On 2017/06/26 22:45:57, mmenke wrote: > LGTM lgtm
3 years, 5 months ago (2017-06-26 22:50:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962603002/1
3 years, 5 months ago (2017-06-26 22:51:05 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-26 22:51:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ae7d311954c7b6b2ea918f381b02...

Powered by Google App Engine
This is Rietveld 408576698