Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 2949053004: MD Settings: fix help/ redirection to only happen on chrome://help (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix help/ redirection to only happen on chrome://help R=tommycli@chromium.org BUG=735149 Review-Url: https://codereview.chromium.org/2949053004 Cr-Commit-Position: refs/heads/master@{#481981} Committed: https://chromium.googlesource.com/chromium/src/+/25472e0c801c621e7bd907bbbc57b317efa56fa0

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : nits #

Patch Set 4 : whoops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -42 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 3 chunks +49 lines, -42 lines 0 comments Download
M chrome/browser/chrome_content_browser_client_unittest.cc View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (17 generated)
Dan Beam
3 years, 6 months ago (2017-06-22 20:24:37 UTC) #1
tommycli
lgtm good tests
3 years, 6 months ago (2017-06-22 22:07:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949053004/40001
3 years, 6 months ago (2017-06-22 22:14:52 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/102053)
3 years, 6 months ago (2017-06-22 22:33:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949053004/60001
3 years, 6 months ago (2017-06-23 01:58:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/294943)
3 years, 6 months ago (2017-06-23 02:12:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949053004/60001
3 years, 6 months ago (2017-06-23 18:26:07 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 19:02:46 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/25472e0c801c621e7bd907bbbc57...

Powered by Google App Engine
This is Rietveld 408576698