Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2962543002: Revert "VM: Reland Inline instance object hash code into object header on 64bit." (Closed)

Created:
3 years, 5 months ago by erikcorry
Modified:
3 years, 5 months ago
Reviewers:
abarth, aam
CC:
dart-fe-team+reviews_google.com, reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: Reland Inline instance object hash code into object header on 64bit." This reverts commit 8378b8fdbf332c9bf2166abb960354bb92492480 due to mysterious crashes on 32 bit ARM with the Flutter Gallery app. R=aam@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3c543bb210711dd6761d592a863fd6f32e1f1279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -498 lines) Patch
M pkg/front_end/testcases/shaker/empty_program.dart.shaker View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/object.cc View 1 chunk +1 line, -9 lines 0 comments Download
M runtime/lib/object_patch.dart View 2 chunks +8 lines, -7 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 2 chunks +6 lines, -9 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/assembler_arm64_test.cc View 2 chunks +2 lines, -64 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.h View 2 chunks +8 lines, -5 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M runtime/vm/assembler_x64_test.cc View 3 chunks +2 lines, -43 lines 0 comments Download
M runtime/vm/become.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/become.cc View 2 chunks +1 line, -5 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/freelist.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/freelist.cc View 1 chunk +1 line, -6 lines 0 comments Download
M runtime/vm/heap.h View 3 chunks +1 line, -10 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 3 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M runtime/vm/method_recognizer.h View 2 chunks +1 line, -14 lines 0 comments Download
M runtime/vm/object.h View 3 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/object.cc View 12 chunks +24 lines, -92 lines 0 comments Download
M runtime/vm/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/raw_object.h View 17 chunks +31 lines, -56 lines 0 comments Download
M runtime/vm/raw_object.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/simulator_arm64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm64.cc View 3 chunks +9 lines, -39 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 5 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 7 chunks +4 lines, -26 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
erikcorry
3 years, 5 months ago (2017-06-26 17:58:41 UTC) #1
aam
Thanks!
3 years, 5 months ago (2017-06-26 18:12:21 UTC) #2
aam
lgtm
3 years, 5 months ago (2017-06-26 18:12:28 UTC) #3
abarth
This patch is blocking updating //dart, which is blocking a stack of other patches.
3 years, 5 months ago (2017-06-26 20:55:01 UTC) #5
erikcorry
Committed patchset #1 (id:1) manually as 3c543bb210711dd6761d592a863fd6f32e1f1279 (presubmit successful).
3 years, 5 months ago (2017-06-26 21:06:15 UTC) #7
abarth
3 years, 5 months ago (2017-06-26 21:19:04 UTC) #8
Message was sent while issue was closed. 
On 2017/06/26 at 21:06:15, erikcorry wrote:
> Committed patchset #1 (id:1) manually as
3c543bb210711dd6761d592a863fd6f32e1f1279 (presubmit successful).

Thanks!

Powered by Google App Engine
This is Rietveld 408576698