ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across iterator usages.

ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across iterator usages.

This code was previously causing a crash because 3 separate vectors were being created, and iterators from each were being compared to each other. It seems that this went undetected for so long because people usually have 1 or 0 unlock keys -- this explains why the bug attached was observed on some accounts but not others. 

BUG=737649
Review-Url: https://codereview.chromium.org/2962173002
Cr-Commit-Position: refs/heads/master@{#483433}
Committed: https://chromium.googlesource.com/chromium/src/+/7c3996033bfbba55546e24e8845d8f76e271ff27

[Ryan Hansberry, 2017-06-29 14:59:09]

Description was changed from

==========
ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across
iterator usages.

BUG=737649
==========

to

==========
ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across
iterator usages.

This code was previously causing a crash because 3 separate vectors were being
created, and iterators from each were being compared to each other. It seems
that this went undetected for so long because people usually have 1 or 0 unlock
keys -- this explains why the bug attached was observed on some accounts but not
others. 

BUG=737649
==========

[Ryan Hansberry, 2017-06-29 14:59:09]

hansberry@chromium.org changed reviewers:
+ tengs@chromium.org

[Tim Song, 2017-06-29 17:01:50]

lgtm

[Ryan Hansberry, 2017-06-29 17:11:12]

The CQ bit was checked by hansberry@chromium.org

[commit-bot: I haz the power, 2017-06-29 17:11:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 18:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498756272359200, "parent_rev":
"7d51399398db180fe1a7a83a95820e56a9fac755", "commit_rev":
"7c3996033bfbba55546e24e8845d8f76e271ff27"}

[commit-bot: I haz the power, 2017-06-29 18:29:48]

Description was changed from

==========
ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across
iterator usages.

This code was previously causing a crash because 3 separate vectors were being
created, and iterators from each were being compared to each other. It seems
that this went undetected for so long because people usually have 1 or 0 unlock
keys -- this explains why the bug attached was observed on some accounts but not
others. 

BUG=737649
==========

to

==========
ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across
iterator usages.

This code was previously causing a crash because 3 separate vectors were being
created, and iterators from each were being compared to each other. It seems
that this went undetected for so long because people usually have 1 or 0 unlock
keys -- this explains why the bug attached was observed on some accounts but not
others. 

BUG=737649

Review-Url: https://codereview.chromium.org/2962173002
Cr-Commit-Position: refs/heads/master@{#483433}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c3996033bfbba55546e24e8845d...
==========

[commit-bot: I haz the power, 2017-06-29 18:29:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7c3996033bfbba55546e24e8845d...