ProximityAuthWebUIHandler: use the same ExternalDeviceInfo vector across iterator usages.

components/proximity_auth/webui/proximity_auth_webui_handler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/proximity_auth/webui/proximity_auth_webui_handler.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/base64url.h"
@@ skipping 521 matching lines @@
 
   cryptauth::CryptAuthDeviceManager* device_manager =
       proximity_auth_client_->GetCryptAuthDeviceManager();
   if (!device_manager)
     return dictionary;
 
   // If |device_info| is a known unlock key, then combine the proto data with
   // the corresponding local device data (e.g. connection status and remote
   // status updates).
   std::string public_key = device_info.public_key();
+  std::vector<cryptauth::ExternalDeviceInfo> unlock_keys =
+      device_manager->GetUnlockKeys();
   auto iterator = std::find_if(
-      device_manager->GetUnlockKeys().begin(),
-      device_manager->GetUnlockKeys().end(),
+      unlock_keys.begin(), unlock_keys.end(),
       [&public_key](const cryptauth::ExternalDeviceInfo& unlock_key) {
         return unlock_key.public_key() == public_key;
       });
 
-  if (iterator == device_manager->GetUnlockKeys().end() ||
+  if (iterator == unlock_keys.end() ||
       selected_remote_device_.public_key != device_info.public_key())
     return dictionary;
 
   // Fill in the current Bluetooth connection status.
   std::string connection_status = kExternalDeviceDisconnected;
   if (life_cycle_ &&
       life_cycle_->GetState() ==
           RemoteDeviceLifeCycle::State::SECURE_CHANNEL_ESTABLISHED) {
     connection_status = kExternalDeviceConnected;
   } else if (life_cycle_) {
@@ skipping 76 matching lines @@
                << "\n  trust_agent_state: "
                << static_cast<int>(status_update.trust_agent_state);
 
   last_remote_status_update_.reset(new RemoteStatusUpdate(status_update));
   std::unique_ptr<base::ListValue> synced_devices = GetRemoteDevicesList();
   web_ui()->CallJavascriptFunctionUnsafe(
       "LocalStateInterface.onRemoteDevicesChanged", *synced_devices);
 }
 
 }  // namespace proximity_auth