Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2962133002: MD History: Update timestamp hover text when item changes (Closed)

Created:
3 years, 5 months ago by tsergeant
Modified:
3 years, 5 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Update timestamp hover text when item changes This fixes an issue where the time title would be stuck on the first value it was set to, never updating as the list was scrolled and changed. The end result is that the code matches patchset 2 of https://codereview.chromium.org/2454303002/. BUG=675056 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2962133002 Cr-Commit-Position: refs/heads/master@{#483630} Committed: https://chromium.googlesource.com/chromium/src/+/47c2896ff9bad0082bf8abddd0e55bfdd843a959

Patch Set 1 : #

Patch Set 2 : Be lazy again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M chrome/browser/resources/md_history/history_item.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
tsergeant
PTAL. I can't think of any way to fix this bug without ditching the laziness. ...
3 years, 5 months ago (2017-06-29 05:52:28 UTC) #8
calamity
Well you _could_ add the listener back on item change.
3 years, 5 months ago (2017-06-29 06:46:51 UTC) #9
tsergeant
Hmm, okay, yeah. Here's a version that should have no load-time performance impact.
3 years, 5 months ago (2017-06-29 07:43:10 UTC) #12
tsergeant
Hmm, okay, yeah. Here's a version that should have no load-time performance impact.
3 years, 5 months ago (2017-06-29 07:43:10 UTC) #13
calamity
lgtm. lgtm.
3 years, 5 months ago (2017-06-30 03:21:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2962133002/40001
3 years, 5 months ago (2017-06-30 03:34:09 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 04:46:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/47c2896ff9bad0082bf8abddd0e5...

Powered by Google App Engine
This is Rietveld 408576698