Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2454303002: [MD History] Add full time hover text to dates in history items. (Closed)

Created:
4 years, 1 month ago by calamity
Modified:
4 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD History] Add full time hover text to dates in history items. BUG=642575 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/55469f608ab2c7333fa55e96969e0117505c2141 Cr-Commit-Position: refs/heads/master@{#428662}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : do less, be lazy #

Total comments: 1

Patch Set 4 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
calamity
4 years, 1 month ago (2016-10-28 02:46:52 UTC) #3
Dan Beam
lgtm w/nit https://codereview.chromium.org/2454303002/diff/20001/chrome/browser/resources/md_history/history_item.js File chrome/browser/resources/md_history/history_item.js (right): https://codereview.chromium.org/2454303002/diff/20001/chrome/browser/resources/md_history/history_item.js#newcode310 chrome/browser/resources/md_history/history_item.js:310: return new Date(item.time).toString(); nit: can we lazily ...
4 years, 1 month ago (2016-10-28 03:41:41 UTC) #4
calamity
https://codereview.chromium.org/2454303002/diff/20001/chrome/browser/resources/md_history/history_item.js File chrome/browser/resources/md_history/history_item.js (right): https://codereview.chromium.org/2454303002/diff/20001/chrome/browser/resources/md_history/history_item.js#newcode310 chrome/browser/resources/md_history/history_item.js:310: return new Date(item.time).toString(); On 2016/10/28 03:41:40, Dan Beam wrote: ...
4 years, 1 month ago (2016-10-28 06:01:58 UTC) #5
Dan Beam
lgtm https://codereview.chromium.org/2454303002/diff/40001/chrome/browser/resources/md_history/history_item.js File chrome/browser/resources/md_history/history_item.js (right): https://codereview.chromium.org/2454303002/diff/40001/chrome/browser/resources/md_history/history_item.js#newcode306 chrome/browser/resources/md_history/history_item.js:306: */ nit: /** @private */
4 years, 1 month ago (2016-10-28 20:43:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2454303002/60001
4 years, 1 month ago (2016-10-31 06:10:43 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-31 06:56:47 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 06:59:27 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/55469f608ab2c7333fa55e96969e0117505c2141
Cr-Commit-Position: refs/heads/master@{#428662}

Powered by Google App Engine
This is Rietveld 408576698